Skip to content

Commit 189a1c0

Browse files
committed
Use target-specific include dirs
1 parent 0bb9995 commit 189a1c0

File tree

9 files changed

+21
-21
lines changed

9 files changed

+21
-21
lines changed

3rdparty/stb_library.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
#pragma clang diagnostic ignored "-Wcast-align"
66
#endif
77

8-
#include <stb/stb_image.h>
8+
#include "stb/stb_image.h"
99

1010
#if defined(__clang__)
1111
#pragma clang diagnostic pop

CMakeLists.txt

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -44,13 +44,6 @@ include(cmake/onetbb.cmake)
4444
message( STATUS "PPC step: Setup external projects" )
4545
include(cmake/gtest.cmake)
4646

47-
############################## Headers ##############################
48-
49-
message( STATUS "PPC step: Setup headers" )
50-
include_directories(3rdparty)
51-
include_directories(modules)
52-
include_directories(tasks)
53-
5447
############################## Modules ##############################
5548

5649
message( STATUS "PPC step: Setup modules" )

cmake/gtest.cmake

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
include_directories(${CMAKE_SOURCE_DIR}/3rdparty/googletest/googletest/include)
21
include(ExternalProject)
32

43
ExternalProject_Add(

cmake/json.cmake

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
include_directories(${CMAKE_SOURCE_DIR}/3rdparty/json/include)
2-
31
include(ExternalProject)
42

53
ExternalProject_Add(

cmake/libenvpp.cmake

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,3 @@
1-
include_directories(${CMAKE_SOURCE_DIR}/3rdparty/libenvpp/include)
2-
include_directories(SYSTEM
3-
${CMAKE_SOURCE_DIR}/3rdparty/libenvpp/external/fmt/include)
4-
51
if(WIN32)
62
set(PPC_FMT_FLAGS "/EHsc /DFMT_CONSTEVAL=inline")
73
else()

cmake/mpi.cmake

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,4 @@
11
find_package(MPI REQUIRED)
2-
if(MPI_FOUND)
3-
include_directories(${MPI_INCLUDE_PATH})
4-
else(MPI_FOUND)
2+
if(NOT MPI_FOUND)
53
message(FATAL_ERROR "MPI NOT FOUND")
64
endif(MPI_FOUND)

cmake/onetbb.cmake

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
include(ExternalProject)
22

3-
include_directories("${CMAKE_SOURCE_DIR}/3rdparty/onetbb/include")
4-
53
if(WIN32)
64
set(ppc_onetbb_TEST_COMMAND
75
"${CMAKE_COMMAND}" -E copy_directory

cmake/openmp.cmake

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ endif()
1616

1717
find_package(OpenMP)
1818
if(OpenMP_FOUND)
19-
include_directories(${OpenMP_C_INCLUDE_DIRS} ${OpenMP_CXX_INCLUDE_DIRS})
2019
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} ${OpenMP_C_FLAGS}")
2120
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${OpenMP_CXX_FLAGS}")
2221
set(CMAKE_EXE_LINKER_FLAGS

modules/core/CMakeLists.txt

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,24 @@ project(${exec_func_lib})
2424
add_library(${exec_func_lib} STATIC ${LIB_SOURCE_FILES})
2525
set_target_properties(${exec_func_lib} PROPERTIES LINKER_LANGUAGE CXX)
2626

27+
# Add include directories to target
28+
target_include_directories(${exec_func_lib} PUBLIC
29+
${CMAKE_SOURCE_DIR}/3rdparty
30+
${CMAKE_SOURCE_DIR}/modules
31+
${CMAKE_SOURCE_DIR}/tasks
32+
)
33+
34+
# Add external project include directories
35+
target_include_directories(${exec_func_lib} PUBLIC
36+
${CMAKE_SOURCE_DIR}/3rdparty/onetbb/include
37+
${CMAKE_SOURCE_DIR}/3rdparty/json/include
38+
${CMAKE_SOURCE_DIR}/3rdparty/googletest/googletest/include
39+
${CMAKE_SOURCE_DIR}/3rdparty/libenvpp/include
40+
)
41+
target_include_directories(${exec_func_lib} SYSTEM PUBLIC
42+
${CMAKE_SOURCE_DIR}/3rdparty/libenvpp/external/fmt/include
43+
)
44+
2745
add_dependencies(${exec_func_lib} ppc_libenvpp)
2846
target_link_directories(${exec_func_lib} PUBLIC
2947
"${CMAKE_BINARY_DIR}/ppc_libenvpp/install/lib")
@@ -64,6 +82,7 @@ if(MPI_LINK_FLAGS)
6482
set_target_properties(${exec_func_lib} PROPERTIES LINK_FLAGS
6583
"${MPI_LINK_FLAGS}")
6684
endif(MPI_LINK_FLAGS)
85+
target_include_directories(${exec_func_lib} PUBLIC ${MPI_INCLUDE_PATH})
6786
target_link_libraries(${exec_func_lib} PUBLIC ${MPI_LIBRARIES})
6887

6988
add_library(stb_image STATIC ${CMAKE_SOURCE_DIR}/3rdparty/stb_image_wrapper.cpp)

0 commit comments

Comments
 (0)