Skip to content

Log failures from MPI workers #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kmichaelk
Copy link
Contributor

No description provided.

@kmichaelk kmichaelk force-pushed the log-mpi-worker-failures branch 2 times, most recently from 0e2d029 to 8b7c999 Compare January 7, 2025 00:11
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 29.41176% with 12 lines in your changes missing coverage. Please review.

Project coverage is 94.71%. Comparing base (60271ff) to head (7c87fe1).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
tasks/mpi/runner.cpp 29.41% 7 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #163      +/-   ##
==========================================
- Coverage   96.12%   94.71%   -1.42%     
==========================================
  Files          33       33              
  Lines         594      605      +11     
  Branches      178      183       +5     
==========================================
+ Hits          571      573       +2     
- Misses          4       11       +7     
- Partials       19       21       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kmichaelk kmichaelk force-pushed the log-mpi-worker-failures branch from 01769ea to a6bc279 Compare January 7, 2025 23:36
@allnes
Copy link
Member

allnes commented Jan 8, 2025

@kmichaelk please resolve conflict

@kmichaelk kmichaelk force-pushed the log-mpi-worker-failures branch 3 times, most recently from 478661a to 86de7f0 Compare January 8, 2025 17:03

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@kmichaelk kmichaelk force-pushed the log-mpi-worker-failures branch from 86de7f0 to 7c87fe1 Compare January 8, 2025 17:04
@aobolensk aobolensk merged commit 0cda45b into learning-process:master Jan 8, 2025
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants