Merge branch 'master' into log-mpi-worker-failures

Author: allnes

Diff for: .clang-tidy

@@ -20,6 +20,7 @@ Checks: >
   -misc-unused-parameters,
   -misc-use-anonymous-namespace,
   -modernize-avoid-c-arrays,
+  -modernize-loop-convert,
   -modernize-use-nodiscard,
   -modernize-use-trailing-return-type,
   -readability-function-cognitive-complexity,

Diff for: modules/core/perf/include/perf.hpp

@@ -27,14 +27,14 @@ struct PerfResults {
 class Perf {
  public:
   // Init performance analysis with initialized task and initialized data
-  explicit Perf(const std::shared_ptr<Task> &task);
+  explicit Perf(const std::shared_ptr<Task>& task_ptr);
   // Set task with initialized task and initialized data for performance
   // analysis c
-  void SetTask(const std::shared_ptr<Task> &task);
+  void SetTask(const std::shared_ptr<Task>& task_ptr);
   // Check performance of full task's pipeline:  pre_processing() ->
   // validation() -> run() -> post_processing()
   void PipelineRun(const std::shared_ptr<PerfAttr>& perf_attr,
-                    const std::shared_ptr<ppc::core::PerfResults>& perf_results);
+                   const std::shared_ptr<ppc::core::PerfResults>& perf_results);
   // Check performance of task's run() function
   void TaskRun(const std::shared_ptr<PerfAttr>& perf_attr, const std::shared_ptr<ppc::core::PerfResults>& perf_results);
   // Pint results for automation checkers
@@ -43,7 +43,7 @@ class Perf {
  private:
   std::shared_ptr<Task> task;
   static void CommonRun(const std::shared_ptr<PerfAttr>& perf_attr, const std::function<void()>& pipeline,
-                         const std::shared_ptr<ppc::core::PerfResults>& perf_results);
+                        const std::shared_ptr<ppc::core::PerfResults>& perf_results);
 };
 
 }  // namespace core

Diff for: modules/core/perf/src/perf.cpp

@@ -7,15 +7,15 @@
 #include <sstream>
 #include <utility>
 
-ppc::core::Perf::Perf(const std::shared_ptr<Task> &task) { SetTask(task); }
+ppc::core::Perf::Perf(const std::shared_ptr<Task>& task_ptr) { SetTask(task_ptr); }
 
-void ppc::core::Perf::SetTask(const std::shared_ptr<Task> &task) {
-  task->get_data()->state_of_testing = TaskData::StateOfTesting::PERF;
-  this->task = task;
+void ppc::core::Perf::SetTask(const std::shared_ptr<Task>& task_ptr) {
+  task_ptr->get_data()->state_of_testing = TaskData::StateOfTesting::PERF;
+  this->task = task_ptr;
 }
 
 void ppc::core::Perf::PipelineRun(const std::shared_ptr<PerfAttr>& perf_attr,
-                                   const std::shared_ptr<ppc::core::PerfResults>& perf_results) {
+                                  const std::shared_ptr<ppc::core::PerfResults>& perf_results) {
   perf_results->type_of_running = PerfResults::TypeOfRunning::PIPELINE;
 
   CommonRun(
@@ -30,7 +30,7 @@ void ppc::core::Perf::PipelineRun(const std::shared_ptr<PerfAttr>& perf_attr,
 }
 
 void ppc::core::Perf::TaskRun(const std::shared_ptr<PerfAttr>& perf_attr,
-                               const std::shared_ptr<ppc::core::PerfResults>& perf_results) {
+                              const std::shared_ptr<ppc::core::PerfResults>& perf_results) {
   perf_results->type_of_running = PerfResults::TypeOfRunning::TASK_RUN;
 
   task->validation();
@@ -45,7 +45,7 @@ void ppc::core::Perf::TaskRun(const std::shared_ptr<PerfAttr>& perf_attr,
 }
 
 void ppc::core::Perf::CommonRun(const std::shared_ptr<PerfAttr>& perf_attr, const std::function<void()>& pipeline,
-                                 const std::shared_ptr<ppc::core::PerfResults>& perf_results) {
+                                const std::shared_ptr<ppc::core::PerfResults>& perf_results) {
   auto begin = perf_attr->current_timer();
   for (uint64_t i = 0; i < perf_attr->num_running; i++) {
     pipeline();

Diff for: modules/core/task/src/task.cpp

@@ -36,8 +36,9 @@ bool ppc::core::Task::post_processing() {
 }
 
 void ppc::core::Task::internal_order_test(const std::string& str) {
-  if (!functions_order.empty() && str == functions_order.back() && str == "run") { return;
-}
+  if (!functions_order.empty() && str == functions_order.back() && str == "run") {
+    return;
+  }
 
   functions_order.push_back(str);
 

Diff for: tasks/omp/example/src/ops_omp.cpp

@@ -63,18 +63,18 @@ bool nesterov_a_test_task_omp::TestOMPTaskParallel::run_impl() {
   auto temp_res = res;
   if (ops == "+") {
 #pragma omp parallel for reduction(+ : temp_res)
-    for (int i : input_) {
-      temp_res += i;
+    for (int i = 0; i < static_cast<int>(input_.size()); i++) {
+      temp_res += input_[i];
     }
   } else if (ops == "-") {
 #pragma omp parallel for reduction(- : temp_res)
-    for (int i : input_) {
-      temp_res -= i;
+    for (int i = 0; i < static_cast<int>(input_.size()); i++) {
+      temp_res -= input_[i];
     }
   } else if (ops == "*") {
 #pragma omp parallel for reduction(* : temp_res)
-    for (int i : input_) {
-      temp_res *= i;
+    for (int i = 0; i < static_cast<int>(input_.size()); i++) {
+      temp_res *= input_[i];
     }
   }
   res = temp_res;