[Merged by Bors] - feat(NumberTheory.NumberField.CanonicalEmbedding): add exists_ne_zero_mem_ringOfIntegers_lt #5650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kim-em
added
the
blocked-by-other-PR
Closed
3 tasks
xroblot
added
the
t-number-theory
leanprover-community-mathlib4-bot
removed
the
blocked-by-other-PR
leanprover-community-mathlib4-bot
added
the
merge-conflict
leanprover-community-mathlib4-bot
removed
the
merge-conflict
bors
bot
changed the base branch from
master
to
ScottCarnahan/BinomialRing2
jcommelin
reviewed
Sep 18, 2023
jcommelin
added
awaiting-author
xroblot
added
awaiting-review
and removed
awaiting-author
jcommelin
reviewed
Sep 19, 2023
jcommelin
changed the title
|
I think this is looking pretty good now. If you fix the two naming issues that I pointed out above, please kick this on the bors queue. bors d+ |
|
βοΈ xroblot can now approve this pull request. To approve and merge a pull request, simply reply with |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Sep 20, 2023
β¦_mem_ringOfIntegers_lt (#5650) This PR proves the following result: ```lean theorem exists_ne_zero_mem_ringOfIntegers_lt (h : minkowski_bound K < volume (convex_body_lt K f)) : β (a : π K), a β 0 β§ β w : InfinitePlace K, w a < f w ``` where `f : InfinitePlace K β ββ₯0` and `convex_body_lt K f` is the set of points `x` such that `βx wβ < f w` for all infinite places `w`. This is a key result in the proof of Dirichlet's unit theorem #5960
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
kodyvajjha
pushed a commit
that referenced
this pull request
Sep 22, 2023
β¦_mem_ringOfIntegers_lt (#5650) This PR proves the following result: ```lean theorem exists_ne_zero_mem_ringOfIntegers_lt (h : minkowski_bound K < volume (convex_body_lt K f)) : β (a : π K), a β 0 β§ β w : InfinitePlace K, w a < f w ``` where `f : InfinitePlace K β ββ₯0` and `convex_body_lt K f` is the set of points `x` such that `βx wβ < f w` for all infinite places `w`. This is a key result in the proof of Dirichlet's unit theorem #5960
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proves the following result:
where
f : InfinitePlace K β ββ₯0andconvex_body_lt K fis the set of pointsxsuch thatβx wβ < f wfor all infinite placesw. This is a key result in the proof of Dirichlet's unit theorem #5960