[Merged by Bors] - feat: port LinearAlgebra.CliffordAlgebra.Grading #5349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kim-em
added
blocked-by-other-PR
eric-wieser
commented
Jun 21, 2023
Comment on lines
182
to
183
| -- TODO: this `simp_rw` is not actually doing anything, lean4#1926 | ||
| simp_rw [Subtype.coe_mk, ZMod.nat_coe_zmod_eq_iff, add_comm n.val] |
There was a problem hiding this comment.
leanprover/lean4#1926. The proof fails without the effect this line is supposed to have.
kim-em
removed
merge-conflict
|
This PR/issue depends on:
|
kim-em
added
the
merge-conflict
Mathbin -> Mathlib fix certain import statements move "by" to end of line add import to Mathlib.lean
eric-wieser
force-pushed
the
port/LinearAlgebra.CliffordAlgebra.Grading
branch
from
dc23f95 to
3ced1df
Compare
kim-em
removed
the
merge-conflict
eric-wieser
added
awaiting-review
and removed
help-wanted
eric-wieser
commented
Jun 22, 2023
Comment on lines
170
to
192
| simp_rw [Subtype.coe_mk, ZMod.nat_coe_zmod_eq_iff, add_comm n.val] | ||
| -- porting note: was `simp_rw [Subtype.coe_mk, ZMod.nat_coe_zmod_eq_iff, add_comm n.val]` | ||
| -- leanprover/lean4#1926 is to blame. | ||
| dsimp only [Subtype.coe_mk] | ||
| let hlean1926 : ∀ val : ℕ, ↑val = n ↔ ∃ k, val = 2 * k + ZMod.val n := by | ||
| intro val | ||
| simp_rw [ZMod.nat_coe_zmod_eq_iff, add_comm n.val] | ||
| have := fun val : ℕ => forall_prop_congr' | ||
| (q := fun property => ∀ x (hx : x ∈ LinearMap.range (ι Q) ^ val), | ||
| P x (Submodule.mem_iSup_of_mem { val := val, property := property } hx)) | ||
| (hq := fun property => Iff.rfl) (hp := hlean1926 val) | ||
| simp_rw [this]; clear this | ||
| -- end porting note |
There was a problem hiding this comment.
This is extremely unfortunate, and is a major regression in simp's ability to deal with dependent types.
eric-wieser
commented
Jun 22, 2023
Comment on lines
+215
to
+217
| let hlean1926'' : x ∈ LinearMap.range (ι Q) ^ 2 | ||
| ↔ x ∈ LinearMap.range (ι Q) * LinearMap.range (ι Q) := by | ||
| rw [pow_two] |
There was a problem hiding this comment.
Interestingly the proof fails if I use a have instead of a let, as then the induction motive below is wrong.
1 task
jcommelin
approved these changes
Jun 23, 2023
kim-em
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Jun 23, 2023
This runs into some annoying problems with leanprover/lean4#1926 which makes working with the dependent types much worse than it was in Lean 3.
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
kim-em
pushed a commit
that referenced
this pull request
Jun 23, 2023
This runs into some annoying problems with leanprover/lean4#1926 which makes working with the dependent types much worse than it was in Lean 3.
kim-em
pushed a commit
that referenced
this pull request
Jun 23, 2023
This runs into some annoying problems with leanprover/lean4#1926 which makes working with the dependent types much worse than it was in Lean 3.
kim-em
pushed a commit
that referenced
this pull request
Jun 25, 2023
This runs into some annoying problems with leanprover/lean4#1926 which makes working with the dependent types much worse than it was in Lean 3.
kbuzzard
pushed a commit
that referenced
this pull request
Jul 6, 2023
This runs into some annoying problems with leanprover/lean4#1926 which makes working with the dependent types much worse than it was in Lean 3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This runs into some annoying problems with leanprover/lean4#1926 which makes working with the dependent types much worse than it was in Lean 3.