[Merged by Bors] - feat: port LinearAlgebra.CliffordAlgebra.Conjugation #5404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mathbin -> Mathlib fix certain import statements move "by" to end of line add import to Mathlib.lean
Mathbin -> Mathlib fix certain import statements move "by" to end of line add import to Mathlib.lean
eric-wieser
added
WIP
kim-em
added
the
blocked-by-other-PR
This was referenced Jun 23, 2023
jcommelin
approved these changes
Jun 23, 2023
kim-em
removed
the
blocked-by-other-PR
|
This PR/issue depends on:
|
kim-em
added
the
merge-conflict
kim-em
removed
the
merge-conflict
|
Thanks 🎉 bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Jun 23, 2023
Annoyingly, Lean 4 cannot work out that `reverse x` where `x : clifford_algebra Q` is referring to `reverse (Q := Q) x`, even though that's the only thing that type checks. Otherwise the only difficulty when porting was the standard `LinearMap.range` dot notation failing thing. Co-authored-by: Jeremy Tan Jie Rui <[email protected]>
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
kim-em
pushed a commit
that referenced
this pull request
Jun 25, 2023
Annoyingly, Lean 4 cannot work out that `reverse x` where `x : clifford_algebra Q` is referring to `reverse (Q := Q) x`, even though that's the only thing that type checks. Otherwise the only difficulty when porting was the standard `LinearMap.range` dot notation failing thing. Co-authored-by: Jeremy Tan Jie Rui <[email protected]>
kbuzzard
pushed a commit
that referenced
this pull request
Jul 6, 2023
Annoyingly, Lean 4 cannot work out that `reverse x` where `x : clifford_algebra Q` is referring to `reverse (Q := Q) x`, even though that's the only thing that type checks. Otherwise the only difficulty when porting was the standard `LinearMap.range` dot notation failing thing. Co-authored-by: Jeremy Tan Jie Rui <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Annoyingly, Lean 4 cannot work out that
reverse xwherex : clifford_algebra Qis referring toreverse (Q := Q) x, even though that's the only thing that type checks.Otherwise the only difficulty when porting was the standard
LinearMap.rangedot notation failing thing.Please rebase this to remove the #5349 commits before merging (I will likely not be around to do so)