[Merged by Bors] - refactor: remove @[simp] from Pi.natCast_def and Pi.intCast_def
#23430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These lemmas prevented general simp lemmas about rings applying to the product ring.
PR summary 7153aeb3a2Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
YaelDillies
approved these changes
Mar 29, 2025
There was a problem hiding this comment.
I was going to ask you to do the same for Prod, but looks like we don't have Prod.natCast_def! (cf Data.Nat.Cast.Prod.
maintainer merge
|
🚀 Pull request has been placed on the maintainer queue by YaelDillies. |
|
Thanks! bors merge |
leanprover-community-mathlib4-bot
added
ready-to-merge
mathlib-bors bot
pushed a commit
that referenced
this pull request
Mar 29, 2025
…#23430) These lemmas prevented general simp lemmas about rings applying to the product ring. Also adds `@[simp]` to a lemma that previously was not simp-normal but now is.
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
@[simp] from Pi.natCast_def and Pi.intCast_def@[simp] from Pi.natCast_def and Pi.intCast_def
riccardobrasca
pushed a commit
that referenced
this pull request
Mar 30, 2025
…#23430) These lemmas prevented general simp lemmas about rings applying to the product ring. Also adds `@[simp]` to a lemma that previously was not simp-normal but now is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These lemmas prevented general simp lemmas about rings applying to the product ring.
Also adds
@[simp]to a lemma that previously was not simp-normal but now is.