refactor: review the simps
projections of OneHom
, MulHom
, MonoidHom
#19860
+103
−122
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
simps
generatecoe_concreteHom
rather thanconcreteHom_apply
.From FLT
In fact, I would love to have both the
coe_
and_apply
projections simultaneously and also to not have to specifysimps (config := .asFn))
every single time we want to generate thecoe_
projection, butsimps
seems to not be able to do that? cc @fpvandoornI must say, after four years of working on mathlib, I still don't understand how one is supposed to use
simps
.