This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
[Merged by Bors] - feat(algebra/module/graded_module): define graded module #14582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjaassoonn
added
the
awaiting-review
eric-wieser
reviewed
Jun 6, 2022
|
It might make sense to handle #14583 first, so that we can avoid having extra scalar rings here. |
eric-wieser
reviewed
Jun 6, 2022
eric-wieser
reviewed
Jun 6, 2022
…ect sum This is a constructive version of `direct_sum.is_internal`, and generalizes the existing `graded_algebra`.
…tion' into jjaassoonn/graded_module
jjaassoonn
added
WIP
mathlib-dependent-issues-bot
added
the
blocked-by-other-PR
…tion' into jjaassoonn/graded_module
…tion' into jjaassoonn/graded_module
mathlib-dependent-issues-bot
removed
the
blocked-by-other-PR
|
@eric-wieser, this PR has been forgotten by me and you. Could you please have a look again please. Thanks. |
kbuzzard
approved these changes
Jan 18, 2023
eric-wieser
reviewed
Jan 18, 2023
alreadydone
approved these changes
Jan 22, 2023
src/algebra/direct_sum/ring.lean
Outdated
Comment on lines
125
to
133
| /-- A graded version of `semiring.to_module`. -/ | ||
| instance gsemiring.to_gmodule (A : ι → Type*) | ||
| [add_monoid ι] [Π (i : ι), add_comm_monoid (A i)] [gsemiring A] : | ||
| graded_monoid.gmodule A A := | ||
| { smul_add := λ _ _, gsemiring.mul_add, | ||
| smul_zero := λ i j, gsemiring.mul_zero, | ||
| add_smul := λ i j, gsemiring.add_mul, | ||
| zero_smul := λ i j, gsemiring.zero_mul, | ||
| ..graded_monoid.gmonoid.to_gmul_action A } |
There was a problem hiding this comment.
I fixed this error here by moving this declaration to the graded_module file. If everyone is happy we can merge my branch then send this PR to bors.
There was a problem hiding this comment.
Also see the latest commit that addressed @kbuzzard's comments.
|
Hmm, this merge didn't go well ... Shouldn't have squash-merged ... should be fine now. |
alreadydone
force-pushed
the
jjaassoonn/graded_module
branch
from
11ade35 to
b1843bb
Compare
leanprover-community-bot-assistant
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Jan 27, 2023
By imitating the current `graded_algebra`, this pr builds `graded_module` over some `graded algebra` Co-authored-by: Eric Wieser @eric-wieser - [x] depends on: #14626 - [x] depends on: #15654 Co-authored-by: Eric Wieser <[email protected]>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By imitating the current
graded_algebra, this pr buildsgraded_moduleover somegraded algebraCo-authored-by: Eric Wieser @eric-wieser
direct_sum.decompositionclass #15654