feat: Simp, made simple #98
Open
+280
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
reviewed
Apr 15, 2025
eric-wieser
reviewed
Apr 15, 2025
b-mehta
reviewed
Apr 15, 2025
eric-wieser
reviewed
Apr 15, 2025
YaelDillies
force-pushed
the
how-to-write-a-simproc
branch
from
5ed721a to
2feca6c
Compare
b-mehta
reviewed
Apr 16, 2025
b-mehta
reviewed
Apr 16, 2025
b-mehta
reviewed
Apr 17, 2025
b-mehta
reviewed
Apr 17, 2025
YaelDillies
pushed a commit
that referenced
this pull request
May 26, 2025
This PR adds the first blog post in a series of three to introduce the concept of simprocs and explain how to write them. The second blog post can be found here: #98 Co-authored-by : Yaël Dillies <[email protected]>
|
Part 1 references this post, so maybe it can also be updated to have working links pointing here too. |
posts/simp-made-simple.md
Outdated
| ``` | ||
| Note: The above snippet is a simplification and the constructors as shown actually belong to `Lean.TransformStep`, which `Lean.Meta.Simp.DStep` is an `abbrev` of. | ||
|
|
||
| <span style="color:red">**(Yaël): Why is there a mismatch in docstrings between `Step.continue` and `DStep.continue`? [Zulip](https://leanprover.zulipchat.com/#narrow/channel/270676-lean4/topic/Simp.2EStep.2Econtinue.20vs.20Simp.2EDStep.2Econtinue/with/509056271)**</span> |
There was a problem hiding this comment.
Do you want to remove this?
YaelDillies
force-pushed
the
how-to-write-a-simproc
branch
2 times, most recently
from
ed3714e to
04f3d50
Compare
Co-authored-by: Paul Lezeau <[email protected]>
Co-authored-by: Eric Wieser <[email protected]>
Co-authored-by: Bhavik Mehta <[email protected]>
Co-authored-by: Bhavik Mehta <[email protected]>
YaelDillies
force-pushed
the
how-to-write-a-simproc
branch
from
04f3d50 to
f7aa206
Compare
Co-authored-by: blizzard_inc <[email protected]>
jcommelin
reviewed
Jun 19, 2025
| For example, `simp [foo, -bar]` means "Simplify using the standard simp lemmas/simprocs except `bar`, with `foo` added". | ||
|
|
||
| A perhaps surprising fact is that every simp lemma is internally turned into a simproc for `simp`'s consumption. | ||
| From then on, we will refer to simp lemmas/simprocs as *procedures*. |
There was a problem hiding this comment.
Suggested change
| From then on, we will refer to simp lemmas/simprocs as *procedures*. | |
| From now on, we will refer to simp lemmas/simprocs as *procedures*. |
posts/simp-made-simple.md
Outdated
| ``` | ||
|
|
||
| `simp` does not consume bare elements of type `Simproc`. | ||
| Instead, a simproc is an element of type `Simproc` annotated with tbe extra data mentioned in the overview subsection, like whether the simproc is `pre` or `post`. |
There was a problem hiding this comment.
The section on Step is great, and contains a lot of detail. These latter sections seem somewhat rushed and the ending of the blogpost feels abrupt to me.
For example, this sentence about annotations with extra data... could that be accompanied by a code block that shows exactly what is going on?
And would it make sense to give the exact definition of the simpM monad, and add a bit more detail on it?
Maybe you could even end with a little cliff hanger about what will happen in the final blogpost?
There was a problem hiding this comment.
Sounds good! I'm planning on spending some extra time adding stuff about SimpM to the post this coming month.
YaelDillies
commented
Jul 13, 2025
Co-authored-by: Yaël Dillies <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second part of #97.
Co-authored-by: Paul Lezeau [email protected]