-
Notifications
You must be signed in to change notification settings - Fork 24
feat: Simprocs for the Working Mathematician #97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Simprocs for the Working Mathematician #97
Conversation
Co-authored-by: Yaël Dillies <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great! I've left a host of minor comments which will hopefully make it even better.
posts/fantastic-simprocs.md
Outdated
link: '' | ||
slug: fantastic-simprocs | ||
tags: 'simp, simproc, meta' | ||
title: Fantastic Simprocs and Where to Find Them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know it's a joke but this PR does not give any indication about where to find simprocs so in my mind the title is not a good fit: it's basically completely inaccurate. If you want to make the joke then perhaps the time to make it is in the follow-up post where you could call it Fantastic Simprocs and how to write them
or something.
posts/fantastic-simprocs.md
Outdated
-- Works since `simp` can simplify `P ∨ ¬ P` to `True`. | ||
simp only [↓reduceIte] | ||
|
||
open Classical |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What? Why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can remove it once you are done proving FermatLastTheorem
😉
posts/fantastic-simprocs.md
Outdated
@@ -118,6 +118,10 @@ The [`Nat.reduceDvd`](https://leanprover-community.github.io/mathlib4_docs/find/ | |||
example : 3 ∣ 9 := by | |||
simp only [Nat.reduceDvd] | |||
|
|||
-- `decide` cannot close this goal. | |||
example (f : Prop → Prop) : f (2 ∣ 4) = f True := by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a nice example!
This PR adds the first blog post in a series of three to introduce the concept of simprocs and explain how to write them.
The second blog post can be found here: #98
Co-authored-by : Yaël Dillies [email protected]
Feedback about the content and corrections are very welcome!