-
Notifications
You must be signed in to change notification settings - Fork 37
feat: implement electra deposits #1424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
in fails
…d state was not being used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR looks good so far, but it's taking me some time to review and try to make some of the functions more clear, so I will leave a batch of comments here and continue with the rest
lib/lambda_ethereum_consensus/state_transition/epoch_processing.ex
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM apart from the readability comments. Regarding process_pending_deposits
we should probably take some time in the future to refactor it and make it more readable but it requires more effort than the suggested alternatives for the other functions.
BTW we went from 424
(in my latest run in electra-support
) to 165
failed tests here, so probably a small summary (num of test x suite) that now pass would be useful in the description of the PR.
Motivation
Implement changes in Electra to deposits + fix all spec-tests related to it.
Description
is_valid_deposit_signature
linkget_validator_from_deposit
linkadd_validator_to_registry
linkMutators.apply_initial_deposit
get_validator_from_deposit
apply_deposit
linkapply_pending_deposit
linkprocess_pending_deposits
linkprocess_operations
linkprocess_deposit
linkapply_deposit
process_deposit_request
linkFixed Spec Tests
Spec test progress
11370 tests, 165 failures, 784 skipped