Skip to content

feat: electra process_operations changes #1426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 97 commits into from
Apr 24, 2025
Merged

feat: electra process_operations changes #1426

merged 97 commits into from
Apr 24, 2025
+466 −37

Conversation

LeanSerra
Copy link
Contributor

@LeanSerra LeanSerra commented Apr 11, 2025 •
edited
Loading

Motivation

Implement the changes made to process_operation by modifying existing for_ops and adding the new process_withdrawal_request and process_consolidation_request. process_deposit_request was done in #1424

Description

  • Modified process_attestation link
  • New get_pending_balance_to_withdraw link
  • Modified process_voluntary_exit link
  • New process_withdrawal_request link
  • New queue_excess_active_balance link
  • New switch_to_compounding_validator link
  • New get_consolidation_churn_limit link
  • New process_consolidation_request link
  • New compute_consolidation_epoch_and_update_churn link

Fixed Spec Tests

test/generated/mainnet/electra/operations.exs:
previous: 333 tests, 23 failures
now: 333 tests, 19 failures

test/generated/minimal/electra/finality.exs:
previous: 5 tests, 5 failures
now: 5 tests, 0 failures

test/generated/minimal/electra/fork_choice.exs:
previous: 56 tests, 38 failures
now: 56 tests, 0 failures

test/generated/minimal/electra/operations.exs:
previous: 366 tests, 45 failures
now: 366 tests, 38 failures

test/generated/minimal/electra/sanity.exs:
previous: 104 tests, 12 failures, 1 skipped
now: 104 tests, 10 failures, 1 skipped

test/generated/minimal/electra/sync.exs:
previous: 1 test, 1 failure
now: 1 test, 0 failures

tests fixed: 57

Spec Test Progress

11370 tests, 108 failures, 784 skipped

LeanSerra added 30 commits April 3, 2025 11:21
@LeanSerra
feat EpochProcessing.process_slashings electra changes

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
Loading
Loading status checks…
ed74379
@LeanSerra
feat compute_proposer_index changes
Loading
Loading status checks…
71b3674
@LeanSerra
feat compute_sync_committees Electra changes
9aa4202
@LeanSerra
fix fork_choice.ex tests were flaky because env var cleanup was not done
Loading
Loading status checks…
f09b71b 
in fails
@LeanSerra
feat eligible_for_activation_queue Electra changes
df45ee4
@LeanSerra
feat new compounding_withdrawal_credential? Electra function
8fb4d63
@LeanSerra
feat new has_compounding_withdrawal_credential Electra function
6e34108
@LeanSerra
feat new has_execution_withdrawal_credential Electra function
620e700
@LeanSerra
feat fully_withdrawable_validator? Electra changes
d904593
@LeanSerra
feat new get_max_effective_balance Electra function
5445583
@LeanSerra
feat partially_withdrawable_validator? Electra changes
5cbc5af
@LeanSerra
fix typo in struct field in has_compounding_withdrawal_credential
753badb
@LeanSerra
feat new get_committee_indices Electra function
29bf08a
@LeanSerra
feat get_attesting_indices Electra changes
Loading
Loading status checks…
17bf479
@LeanSerra
lint remove unnecessary parentheses in if
Loading
Loading status checks…
42b0bfb
@LeanSerra
feat slash_validator Electra changes
6df1b36
@LeanSerra
feat new get_balance_churn_limit Electra function
9e13ad5
@LeanSerra
feat new get_activation_exit_churn_limit Electra function
abc2585
@LeanSerra
feat compute_exit_epoch_and_churn Electra function
5b7e5dc
@LeanSerra
feat initiate_validator_exit Electra changes
4eddb4b
@LeanSerra
feat process_registry_updates Electra changes
44a00ec
@LeanSerra
refactor remove unused eject_validator(_,_,_, false) variant
9bc3a0b
@LeanSerra
fix compute_exit_epoch_and_update_churn wrong exit_balance calculation
ed8be8a
@LeanSerra
Merge branch 'electra-support' into electra_predicates
Loading
Loading status checks…
c084913
@LeanSerra
fix additional_epochs calculation in compute_exit_epoch_and_update_churn
6ec0216
@LeanSerra
fix wrong values for constants in minimal config
Loading
Loading status checks…
7da3d5a
@LeanSerra
Merge branch 'electra_predicates' into electra_validator_exit
Loading
Loading status checks…
70d40aa
@LeanSerra
feat process_epoch changes + deposits/consolidation scaffolding
e4e8607
@LeanSerra
feat new is_valid_deposit_signature Electra function
0e53f57
@LeanSerra
feat get_validator_from_deposit Electra changes
12ed2d3
Base automatically changed from electra_deposits to electra-support April 21, 2025 12:06
@LeanSerra
Merge branch 'electra-support' into electra_process_operations
Loading
Loading status checks…
2eb2ce3
@LeanSerra
fix added diff lines
Loading
Loading status checks…
5bdef50
@LeanSerra
fix added diff lines
Loading
Loading status checks…
e163179
@LeanSerra LeanSerra marked this pull request as ready for review April 21, 2025 13:31
@LeanSerra LeanSerra requested a review from a team as a code owner April 21, 2025 13:31
rodrigo-o
rodrigo-o reviewed Apr 23, 2025
View reviewed changes
Copy link
Collaborator

@rodrigo-o rodrigo-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already reviewed constants, accessors and mutators and they look great, still going through operations

rodrigo-o
rodrigo-o reviewed Apr 23, 2025
View reviewed changes
Copy link
Collaborator

@rodrigo-o rodrigo-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Half-way in operations, left a couple of comments

rodrigo-o
rodrigo-o reviewed Apr 23, 2025
View reviewed changes
Copy link
Collaborator

@rodrigo-o rodrigo-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more comments

LeanSerra and others added 2 commits April 23, 2025 17:04
@LeanSerra @rodrigo-o
refactor use pattern matching for Operations.check_data_index_zero
Loading
Loading status checks…
95f69b1 
Co-authored-by: Rodrigo Oliveri <[email protected]>
@LeanSerra @rodrigo-o
refactor use cond clause for withdrawal_request_type in process_withd…
Loading
Loading status checks…
30952b6 
…rawal_request

Co-authored-by: Rodrigo Oliveri <[email protected]>
rodrigo-o
rodrigo-o reviewed Apr 23, 2025
View reviewed changes
Copy link
Collaborator

@rodrigo-o rodrigo-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, left some final comments!

rodrigo-o
rodrigo-o approved these changes Apr 24, 2025
View reviewed changes
Copy link
Collaborator

@rodrigo-o rodrigo-o left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 🚀 Just one nit!

@LeanSerra LeanSerra merged commit e5ef002 into electra-support Apr 24, 2025
10 of 14 checks passed
@LeanSerra LeanSerra deleted the electra_process_operations branch April 24, 2025 19:16
rodrigo-o added a commit that referenced this pull request Apr 25, 2025
@LeanSerra @rodrigo-o
feat: electra process_operations changes (#1426)
61b1faa 
Co-authored-by: Rodrigo Oliveri <[email protected]>
rodrigo-o added a commit that referenced this pull request Apr 25, 2025
@LeanSerra @rodrigo-o
feat: electra process_operations changes (#1426)
742e3ad 
Co-authored-by: Rodrigo Oliveri <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodrigo-o rodrigo-o

Assignees

@LeanSerra LeanSerra

Labels
electra elixir Pull requests that update Elixir code
Projects
Lambda Ethereum Consensus Node
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LeanSerra @rodrigo-o