feat: electra container and ssz support #1400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigo-o
changed the title
ElFantasma
reviewed
Mar 26, 2025
ElFantasma
reviewed
Mar 26, 2025
rodrigo-o
commented
Mar 28, 2025
There was a problem hiding this comment.
This file was needed to be replaced by one of the current electra spec-test
There was a problem hiding this comment.
This change reduce our unit test failures from 13 to 4
There was a problem hiding this comment.
Here is an issue tracking the still failing test: #1408
rodrigo-o
commented
Mar 28, 2025
There was a problem hiding this comment.
We need to check for this one, it's not exactly as the previous one and the test related to it still fail. I'll create an issue for this specific error
rodrigo-o
commented
Mar 28, 2025
| @@ -35,7 +35,7 @@ defmodule SpecTestUtils do | |||
| end | |||
|
|
|||
| def sanitize_yaml({k, v}), do: {String.to_atom(k), sanitize_yaml(v)} | |||
| def sanitize_yaml("0x"), do: <<0>> | |||
| def sanitize_yaml("0x"), do: [] | |||
ElFantasma
reviewed
Apr 1, 2025
ElFantasma
approved these changes
Apr 1, 2025
This was referenced Apr 10, 2025
rodrigo-o
added a commit
that referenced
this pull request
Apr 25, 2025
rodrigo-o
added a commit
that referenced
this pull request
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR adds all new containers and modify the already existing one with the new electra spec
Description
To be able to add new types we need to add them in 2 different places, one in the elixir code and another one in the ssz_nif crate. Also, apart from the container implementations we needed to add the constants and preset to be able to configure them.
This PR address an issue that happened on all spec-test outside of the general suite, where everyone failed with
OffsetSkipsVariableBytes(#1405). Now, all those fail with different issues which enables us to tackle them separately.Also after finding out that the config/preset in the rust ssz_nif is fixed instead of taking from a yaml (as done in elixir) I created an issue for reworking it, this is something that is too error prone to maintain as it is but probably something to tackle after the electra implementation: #1402
We also fixed a couple of small ssz issues spread around, one was related to an incorrect mapping of the "0x" literal string (#1398) and another one that happened specificaly in the random test suite (#1403).
Next Steps
Before star tackling specific electra task we might want to tackle #1407 & #1408 to make sure all our unit test still run before starting to tackle the logic of the electra additions. We also want to make sure both Docker and kurtosis work as expected #1412 and at least have a simple version of assertoor in place #1413 although it probably is not complete until the actual fork updates are made to the code.
Closes #1405 & #1403 & #1398