Skip to content

Generic SSZ encode/decode issues on general 1.5.0-beta.3 spec tests #1398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rodrigo-o opened this issue Mar 18, 2025 · 1 comment
Closed
Labels
electra spec-test Ethereum Foundation consensus spec tests ssz Issues related to Simple Serialize (SSZ)

Comments

@rodrigo-o
Copy link
Collaborator

This appears to be unrelated to the electra update and instead being something now tested in the phase0 general spec tests that fails on a particular parameter (spectest version 1.5.0-beta.3):

1) test c:general f:phase0 r:ssz_generic h:containers s:valid -> ComplexTestStruct_nil_8 (General.Phase0.SszGenericTest)
     test/generated/general/phase0/ssz_generic.exs:9689
     Assertion with == failed
     code:  assert deserialized == real_deserialized
     left:  %Helpers.SszStaticContainers.ComplexTestStruct{
              A: 9027,
              B: [],
              C: 140,
              D: [],
              E: %Helpers.SszStaticContainers.VarTestStruct{A: 54691, B: [], C: 202},
    [...]
    right: %Helpers.SszStaticContainers.ComplexTestStruct{
              A: 9027,
              B: [],
              C: 140,
              D: [0],
              E: %Helpers.SszStaticContainers.VarTestStruct{A: 54691, B: [], C: 202},

This can be easily replicated on the electra-support branch running make spec-test-general-*.

14 test fail equally on that suite and they all have the same difference: [] instead of [0].

@rodrigo-o rodrigo-o added spec-test Ethereum Foundation consensus spec tests ssz Issues related to Simple Serialize (SSZ) electra labels Mar 19, 2025
@rodrigo-o
Copy link
Collaborator Author

Closed in #1400

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
electra spec-test Ethereum Foundation consensus spec tests ssz Issues related to Simple Serialize (SSZ)
Projects
Development

No branches or pull requests

1 participant