feat(l1): running localnet with client comparisions #3221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lines of code reportTotal lines added: Detailed view |
rodrigo-o
commented
Jun 20, 2025
| @@ -111,6 +111,7 @@ pub async fn init_rollup_store(data_dir: &str) -> StoreRollup { | |||
| } | |||
|
|
|||
| pub fn init_blockchain(evm_engine: EvmEngine, store: Store) -> Arc<Blockchain> { | |||
| info!("Initiating blockchain with EVM: {}", evm_engine); | |||
There was a problem hiding this comment.
This is useful to know which evm was configured on startup as with other logs showing config at the init steps.
rodrigo-o
commented
Jun 20, 2025
Comment on lines
+395
to
+399
| "[METRIC] BLOCK EXECUTION THROUGHPUT ({}): {:.2} Ggas/s TIME SPENT: {:.0} ms. Gas Used: {:.0}%, #Txs: {}.", | ||
| block.header.number, | ||
| throughput, | ||
| interval, | ||
| (block.header.gas_used as f64 / block.header.gas_limit as f64) * 100.0, |
There was a problem hiding this comment.
Small addition to show block number and gas_used% along the already shown data in this log.
rodrigo-o
commented
Jun 20, 2025
rodrigo-o
changed the title
mpaulucci
reviewed
Jun 20, 2025
mpaulucci
approved these changes
Jun 23, 2025
fedacking
approved these changes
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We want to be able to spin up a local network with 3 nodes, ethrex[levm], ethrex[revm] and reth an be able to compare throughput between them on different spamoor configurations.
Description
This PR add a new make target that spin-up a localnet with ethrex[levm], ethrex[revm] and reth, enable the metrics exporter, and prepare the dashboard to be able to be used in arbitrary datasources, both imported or provisioned, automatically setting a datasource variable to the default prometheus.