Skip to content

feat(core): allow setting syncmode from run-hive Makefile targets #2597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 30, 2025

Conversation

fmoletta
Copy link
Contributor

Motivation
Allow running hive tests with snap sync using the available Makefile targets and passing the optional SYNCMODE=snap argument

Description

  • Add SYNCOMDE variable to Makefile with default value "full"
  • Set syncmode ethrex flag on hive Makefile targets according to above variable

Closes #issue_number

@fmoletta fmoletta marked this pull request as ready for review April 25, 2025 15:33
@fmoletta fmoletta requested a review from a team as a code owner April 25, 2025 15:33
Copy link

Lines of code report

Total lines added: 226
Total lines removed: 65
Total lines changed: 291

Detailed view
+------------------------------------------------+-------+------+
| File                                           | Lines | Diff |
+------------------------------------------------+-------+------+
| ethrex/crates/l2/contracts/deployer.rs         | 766   | -32  |
+------------------------------------------------+-------+------+
| ethrex/crates/l2/sequencer/l1_committer.rs     | 394   | -29  |
+------------------------------------------------+-------+------+
| ethrex/crates/l2/utils/config/committer.rs     | 24    | -1   |
+------------------------------------------------+-------+------+
| ethrex/crates/l2/utils/config/toml_parser.rs   | 260   | -3   |
+------------------------------------------------+-------+------+
| ethrex/crates/vm/backends/revm/execution_db.rs | 123   | +123 |
+------------------------------------------------+-------+------+
| ethrex/crates/vm/backends/revm/mod.rs          | 607   | +14  |
+------------------------------------------------+-------+------+
| ethrex/crates/vm/backends/revm/mods.rs         | 38    | +38  |
+------------------------------------------------+-------+------+
| ethrex/crates/vm/levm/src/call_frame.rs        | 135   | +12  |
+------------------------------------------------+-------+------+
| ethrex/crates/vm/levm/src/constants.rs         | 51    | +4   |
+------------------------------------------------+-------+------+
| ethrex/crates/vm/levm/src/environment.rs       | 38    | +10  |
+------------------------------------------------+-------+------+
| ethrex/crates/vm/levm/src/errors.rs            | 241   | +13  |
+------------------------------------------------+-------+------+
| ethrex/crates/vm/levm/src/utils.rs             | 540   | +12  |
+------------------------------------------------+-------+------+

@fmoletta fmoletta added this pull request to the merge queue Apr 30, 2025
Merged via the queue into main with commit 7c5ff95 Apr 30, 2025
20 checks passed
@fmoletta fmoletta deleted the set-syncmode-hive-makefile branch April 30, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants