Skip to content

Commit 7c5ff95

Browse files
authored
feat(core): allow setting syncmode from run-hive Makefile targets (#2597)
**Motivation** Allow running hive tests with snap sync using the available Makefile targets and passing the optional SYNCMODE=snap argument <!-- Why does this pull request exist? What are its goals? --> **Description** * Add `SYNCOMDE` variable to Makefile with default value "full" * Set `syncmode` ethrex flag on hive Makefile targets according to above variable <!-- A clear and concise general description of the changes this PR introduces --> <!-- Link to issues: Resolves #111, Resolves #222 --> Closes #issue_number
1 parent 6f4ce05 commit 7c5ff95

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

Makefile

+4-3
Original file line numberDiff line numberDiff line change
@@ -111,6 +111,7 @@ TEST_PATTERN ?= /
111111
SIM_LOG_LEVEL ?= 4
112112
EVM_BACKEND := revm
113113
SIM_PARALLELISM := 16
114+
SYNCMODE := full
114115

115116
L1_CLIENT ?= ethrex
116117

@@ -127,13 +128,13 @@ display-hive-alternatives:
127128
# For example, to run the rpc-compat suites for eth_chainId & eth_blockNumber you should run:
128129
# `make run-hive SIMULATION=ethereum/rpc-compat TEST_PATTERN="/eth_chainId|eth_blockNumber"`
129130
run-hive: display-hive-alternatives build-image setup-hive ## 🧪 Run Hive testing suite
130-
cd hive && ./hive --client $(L1_CLIENT) --ethrex.flags "--evm $(EVM_BACKEND)" --sim $(SIMULATION) --sim.limit "$(TEST_PATTERN)" --sim.parallelism "$(SIM_PARALLELISM)"
131+
cd hive && ./hive --client $(L1_CLIENT) --ethrex.flags "--evm $(EVM_BACKEND) --syncmode $(SYNCMODE)" --sim $(SIMULATION) --sim.limit "$(TEST_PATTERN)" --sim.parallelism "$(SIM_PARALLELISM)"
131132

132133
run-hive-all: display-hive-alternatives build-image setup-hive ## 🧪 Run all Hive testing suites
133-
cd hive && ./hive --client $(L1_CLIENT) --ethrex.flags "--evm $(EVM_BACKEND)" --sim ".*" --sim.parallelism "$(SIM_PARALLELISM)"
134+
cd hive && ./hive --client $(L1_CLIENT) --ethrex.flags "--evm $(EVM_BACKEND) --syncmode $(SYNCMODE)" --sim ".*" --sim.parallelism "$(SIM_PARALLELISM)"
134135

135136
run-hive-debug: display-hive-alternatives build-image setup-hive ## 🐞 Run Hive testing suite in debug mode
136-
cd hive && ./hive --sim $(SIMULATION) --client $(L1_CLIENT) --ethrex.flags "--evm $(EVM_BACKEND)" --sim.loglevel $(SIM_LOG_LEVEL) --sim.limit "$(TEST_PATTERN)" --sim.parallelism "$(SIM_PARALLELISM)" --docker.output
137+
cd hive && ./hive --sim $(SIMULATION) --client $(L1_CLIENT) --ethrex.flags "--evm $(EVM_BACKEND) --syncmode $(SYNCMODE)" --sim.loglevel $(SIM_LOG_LEVEL) --sim.limit "$(TEST_PATTERN)" --sim.parallelism "$(SIM_PARALLELISM)" --docker.output
137138

138139
clean-hive-logs: ## 🧹 Clean Hive logs
139140
rm -rf ./hive/workspace/logs

0 commit comments

Comments
 (0)