Skip to content

chore: Set imagePullPolicy to IfNotPresent #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 11, 2025
Merged

chore: Set imagePullPolicy to IfNotPresent #366

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ IMG_REPOSITORY ?= quay.io/kubevirt/vm-console-proxy
IMG_TAG ?= latest
IMG ?= ${IMG_REPOSITORY}:${IMG_TAG}

IMG_PULL_POLICY ?= IfNotPresent

SRC_PATHS_TESTS = ./pkg/...
PROJECT_NAME = vm-console-proxy
MANIFETS_PATH = ./manifests
Expand Down Expand Up @@ -38,7 +40,9 @@ push-container:

.PHONY: manifests
manifests:
cd manifests && IMG_REPOSITORY=${IMG_REPOSITORY} IMG_TAG=${IMG_TAG} envsubst < kustomization.yaml.in > kustomization.yaml
cd manifests && \
IMG_REPOSITORY=${IMG_REPOSITORY} IMG_TAG=${IMG_TAG} IMG_PULL_POLICY=${IMG_PULL_POLICY}\
envsubst < kustomization.yaml.in > kustomization.yaml

.PHONY: kustomize
kustomize: $(KUSTOMIZE) ## Download kustomize locally if necessary.
Expand Down Expand Up @@ -66,6 +70,7 @@ release-manifests: kustomize manifests
$(KUSTOMIZE) build ${MANIFETS_PATH} > ./_out/${PROJECT_NAME}.yaml

.PHONY: deploy
deploy: IMG_PULL_POLICY := Always
deploy: manifests
oc apply -k manifests

Expand Down
2 changes: 1 addition & 1 deletion manifests/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ spec:
containers:
- command:
- /console
imagePullPolicy: Always
imagePullPolicy: IfNotPresent
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure this isn't going to cause issues in dev environments? I.e. Now it will not re-pull the image after a change.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be nice to have a small guide in the dev docs to remind us to patch this in dev, if Felix's concern applies.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've changed the Makefile to set it to Always when using make deploy.

args: []
image: console:latest
name: console
Expand Down
16 changes: 16 additions & 0 deletions manifests/kustomization.yaml.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,3 +18,19 @@ images:
- name: console
newName: ${IMG_REPOSITORY}
newTag: ${IMG_TAG}

patches:
- target:
kind: Deployment
name: vm-console-proxy
patch: |
apiVersion: apps/v1
kind: Deployment
metadata:
name: vm-console-proxy
spec:
template:
spec:
containers:
- name: console
imagePullPolicy: ${IMG_PULL_POLICY}