chore: Set imagePullPolicy to IfNotPresent #366
Conversation
kubevirt-bot
added
release-note
| @@ -24,7 +24,7 @@ spec: | |||
| containers: | |||
| - command: | |||
| - /console | |||
| imagePullPolicy: Always | |||
| imagePullPolicy: IfNotPresent | |||
There was a problem hiding this comment.
Are you sure this isn't going to cause issues in dev environments? I.e. Now it will not re-pull the image after a change.
There was a problem hiding this comment.
Will be nice to have a small guide in the dev docs to remind us to patch this in dev, if Felix's concern applies.
There was a problem hiding this comment.
I've changed the Makefile to set it to Always when using make deploy.
This is according to best practices: https://redhat-best-practices-for-k8s.github.io/guide/#k8s-best-practices-use-imagepullpolicy:-ifnotpresent In a development environment, when using 'make deploy' the pull policy is set to Always. Signed-off-by: Andrej Krejcir <[email protected]>
akrejcir
force-pushed
the
set-pull-policy
branch
from
92094b1 to
6abd9db
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 0xFelix The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
What this PR does / why we need it:
This is according to best practices:
https://redhat-best-practices-for-k8s.github.io/guide/#k8s-best-practices-use-imagepullpolicy:-ifnotpresent
Which issue(s) this PR fixes:
Jira: https://issues.redhat.com/browse/CNV-67394
Release note: