Skip to content

don't call startKicServiceTunnel for non-kic drivers #20863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 4, 2025
Merged

don't call startKicServiceTunnel for non-kic drivers #20863

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5ae4760
don't call startKicServiceTunnel for non-kic drivers
prezha May 31, 2025
d5aa8f9
warn about exposing ClusterIP services for all drivers
prezha Jun 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions cmd/minikube/cmd/service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,18 +163,20 @@ You may select another namespace by using 'minikube service {{.service}} -n <nam
for _, svc := range noNodePortServices {
noNodePortSvcNames = append(noNodePortSvcNames, fmt.Sprintf("%s/%s", svc.Namespace, svc.Name))
}
if len(noNodePortServices) != 0 {
if len(noNodePortServices) > 0 {
out.WarningT("Services {{.svc_names}} have type \"ClusterIP\" not meant to be exposed, however for local development minikube allows you to access this !", out.V{"svc_names": noNodePortSvcNames})
}

if driver.NeedsPortForward(co.Config.Driver) && services != nil {
startKicServiceTunnel(services, cname, co.Config.Driver)
if driver.NeedsPortForward(co.Config.Driver) {
svcs := services
if len(svcs) == 0 && len(noNodePortServices) > 0 {
svcs = noNodePortServices
}
if len(svcs) > 0 {
startKicServiceTunnel(svcs, cname, co.Config.Driver)
}
} else if !serviceURLMode {
openURLs(data)
if len(noNodePortServices) != 0 {
startKicServiceTunnel(noNodePortServices, cname, co.Config.Driver)
}

}
},
}
Expand Down
Loading