Skip to content

don't call startKicServiceTunnel for non-kic drivers #20863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

prezha
Copy link
Contributor

@prezha prezha commented May 31, 2025

fixes: #18825
fixes: #19878

before: as described in the issues listed above

after

$ minikube start -p kic --driver docker
$ minikube start -p kvm --driver kvm2
$ minikube profile list
|---------|-----------|---------|----------------|------|---------|--------|-------|----------------|--------------------|
| Profile | VM Driver | Runtime |       IP       | Port | Version | Status | Nodes | Active Profile | Active Kubecontext |
|---------|-----------|---------|----------------|------|---------|--------|-------|----------------|--------------------|
| kic     | docker    | docker  | 192.168.58.2   | 8443 | v1.33.1 | OK     |     1 |                | *                  |
| kvm     | kvm2      | docker  | 192.168.50.204 | 8443 | v1.33.1 | OK     |     1 |                |                    |
|---------|-----------|---------|----------------|------|---------|--------|-------|----------------|--------------------|

docker driver

$ minikube service list -p kic
|-------------|------------|--------------|-----|
|  NAMESPACE  |    NAME    | TARGET PORT  | URL |
|-------------|------------|--------------|-----|
| default     | kubernetes | No node port |     |
| kube-system | kube-dns   | No node port |     |
|-------------|------------|--------------|-----|
$ minikube service --all -p kic
|-----------|------------|-------------|--------------|
| NAMESPACE |    NAME    | TARGET PORT |     URL      |
|-----------|------------|-------------|--------------|
| default   | kubernetes |             | No node port |
|-----------|------------|-------------|--------------|
😿  service default/kubernetes has no node port
$ minikube service --all --url -p kic
😿  service default/kubernetes has no node port
$ kubectl --context=kic create deployment hello-minikube1 --image=kicbase/echo-server:1.0
deployment.apps/hello-minikube1 created
$ kubectl --context=kic expose deployment hello-minikube1 --type=NodePort --port=8080
service/hello-minikube1 exposed 
$ minikube service list -p kic
|-------------|-----------------|--------------|---------------------------|
|  NAMESPACE  |      NAME       | TARGET PORT  |            URL            |
|-------------|-----------------|--------------|---------------------------|
| default     | hello-minikube1 |         8080 | http://192.168.58.2:31243 |
| default     | kubernetes      | No node port |                           |
| kube-system | kube-dns        | No node port |                           |
|-------------|-----------------|--------------|---------------------------|
minikube service --all -p kic
|-----------|-----------------|-------------|---------------------------|
| NAMESPACE |      NAME       | TARGET PORT |            URL            |
|-----------|-----------------|-------------|---------------------------|
| default   | hello-minikube1 |        8080 | http://192.168.58.2:31243 |
|-----------|-----------------|-------------|---------------------------|
|-----------|------------|-------------|--------------|
| NAMESPACE |    NAME    | TARGET PORT |     URL      |
|-----------|------------|-------------|--------------|
| default   | kubernetes |             | No node port |
|-----------|------------|-------------|--------------|
😿  service default/kubernetes has no node port
🎉  Opening service default/hello-minikube1 in default browser...
$ minikube service --all --url -p kic
http://192.168.58.2:31243
😿  service default/kubernetes has no node port
$ minikube service hello-minikube1 --url -p kic
http://192.168.58.2:31243
$ minikube service hello-minikube1 -p kic
|-----------|-----------------|-------------|---------------------------|
| NAMESPACE |      NAME       | TARGET PORT |            URL            |
|-----------|-----------------|-------------|---------------------------|
| default   | hello-minikube1 |        8080 | http://192.168.58.2:31243 |
|-----------|-----------------|-------------|---------------------------|
🎉  Opening service default/hello-minikube1 in default browser...

kvm driver

$ minikube service list -p kvm
|-------------|------------|--------------|-----|
|  NAMESPACE  |    NAME    | TARGET PORT  | URL |
|-------------|------------|--------------|-----|
| default     | kubernetes | No node port |     |
| kube-system | kube-dns   | No node port |     |
|-------------|------------|--------------|-----|
$ minikube service --all -p kvm
|-----------|------------|-------------|--------------|
| NAMESPACE |    NAME    | TARGET PORT |     URL      |
|-----------|------------|-------------|--------------|
| default   | kubernetes |             | No node port |
|-----------|------------|-------------|--------------|
😿  service default/kubernetes has no node port
$ minikube service --all --url -p kvm
😿  service default/kubernetes has no node port
$ kubectl --context=kvm create deployment hello-minikube1 --image=kicbase/echo-server:1.0
deployment.apps/hello-minikube1 created
$ kubectl --context=kvm expose deployment hello-minikube1 --type=NodePort --port=8080
service/hello-minikube1 exposed
$ minikube service list -p kvm
|-------------|-----------------|--------------|-----------------------------|
|  NAMESPACE  |      NAME       | TARGET PORT  |             URL             |
|-------------|-----------------|--------------|-----------------------------|
| default     | hello-minikube1 |         8080 | http://192.168.50.204:31145 |
| default     | kubernetes      | No node port |                             |
| kube-system | kube-dns        | No node port |                             |
|-------------|-----------------|--------------|-----------------------------|
minikube service --all -p kvm
|-----------|-----------------|-------------|-----------------------------|
| NAMESPACE |      NAME       | TARGET PORT |             URL             |
|-----------|-----------------|-------------|-----------------------------|
| default   | hello-minikube1 |        8080 | http://192.168.50.204:31145 |
|-----------|-----------------|-------------|-----------------------------|
|-----------|------------|-------------|--------------|
| NAMESPACE |    NAME    | TARGET PORT |     URL      |
|-----------|------------|-------------|--------------|
| default   | kubernetes |             | No node port |
|-----------|------------|-------------|--------------|
😿  service default/kubernetes has no node port
🎉  Opening service default/hello-minikube1 in default browser...
$ minikube service --all --url -p kvm
http://192.168.50.204:31145
😿  service default/kubernetes has no node port
$ minikube service hello-minikube1 --url -p kvm
http://192.168.50.204:31145
$ minikube service hello-minikube1 -p kvm
|-----------|-----------------|-------------|-----------------------------|
| NAMESPACE |      NAME       | TARGET PORT |             URL             |
|-----------|-----------------|-------------|-----------------------------|
| default   | hello-minikube1 |        8080 | http://192.168.50.204:31145 |
|-----------|-----------------|-------------|-----------------------------|
🎉  Opening service default/hello-minikube1 in default browser...

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 31, 2025
@k8s-ci-robot k8s-ci-robot requested review from medyagh and spowelljr May 31, 2025 23:50
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: prezha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

service command executes wrong helper service command errors with kvm2 driver on Debian Testing
2 participants