Skip to content

Adding conformance report for Kubvernor #1316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Adding conformance report for Kubvernor #1316

wants to merge 1 commit into from
+36 −0

Conversation

dawid-nowak
Copy link

No description provided.

@netlify Netlify
Copy link

netlify bot commented Aug 6, 2025 •
edited
Loading

✅ Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 10dc47a
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/6893bd33dd2fe1000821803a
😎 Deploy Preview https://deploy-preview-1316--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 6, 2025
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 6, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @dawid-nowak. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 6, 2025
@dawid-nowak
Copy link
Author

ping @ahg-g @nirrozenbaum

robscott
robscott approved these changes Aug 13, 2025
View reviewed changes
Copy link
Member

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dawid-nowak!

/ok-to-test

conformance/reports/v0.5.0/gateway/kubvernor/kubvernor-inference-conformance-output-0.1.1.yaml
Comment on lines +4 to +5
gatewayAPIChannel: UNDEFINED
gatewayAPIVersion: UNDEFINED
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What version of Gateway API CRDs did you run this against?

@zetxqx can you take a look to confirm we're automatically populating this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++. that field should be required (we cannot leave UNDEFINED).
automation to populate it would be great.
a user can't know which version to use to get this to work.

conformance/reports/v0.5.0/gateway/kubvernor/kubvernor-inference-conformance-output-0.1.1.yaml
gatewayAPIVersion: UNDEFINED
implementation:
contact:
- [email protected]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of implementations also just link to an OSS repo to file an issue if you want to avoid some email spam - up to you.

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 13, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dawid-nowak, robscott
Once this PR has been reviewed and has the lgtm label, please assign kfswain for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahg-g ahg-g Awaiting requested review from ahg-g

@nirrozenbaum nirrozenbaum Awaiting requested review from nirrozenbaum

1 more reviewer

@robscott robscott robscott approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dawid-nowak @k8s-ci-robot @robscott @nirrozenbaum