Skip to content

[WIP] Upgrade CAPI to v1.10.0-rc.0 #5563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from

Conversation

nawazkh
Copy link
Member

@nawazkh nawazkh commented Apr 11, 2025

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • cherry-pick candidate

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Apr 11, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign timothysc for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 11, 2025
Copy link

codecov bot commented Apr 11, 2025

Codecov Report

Attention: Patch coverage is 52.17391% with 44 lines in your changes missing coverage. Please review.

Project coverage is 52.83%. Comparing base (df608bd) to head (e3c1ffd).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
api/v1beta1/azurecluster_webhook.go 72.09% 8 Missing and 4 partials ⚠️
exp/api/v1beta1/azuremachinepoolmachine_webhook.go 0.00% 12 Missing ⚠️
api/v1beta1/azureclustertemplate_webhook.go 40.00% 9 Missing ⚠️
api/v1beta1/azuremanagedclustertemplate_webhook.go 0.00% 5 Missing ⚠️
api/v1beta1/azureclusteridentity_webhook.go 75.00% 3 Missing ⚠️
api/v1beta1/azuremanagedcluster_webhook.go 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5563      +/-   ##
==========================================
- Coverage   52.86%   52.83%   -0.04%     
==========================================
  Files         272      272              
  Lines       29474    29502      +28     
==========================================
+ Hits        15582    15587       +5     
- Misses      13080    13103      +23     
  Partials      812      812              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nawazkh
Copy link
Member Author

nawazkh commented Apr 11, 2025

A better error than earlier

panic: input.KubeConfigPath is required for DumpAllResources
	Expected
	    <string>: 
	not to be empty
 goroutine 1 [running]:
main.Fail({0xc00055ec60?, 0xc000736fc0?}, {0x7983fe0?, 0xc00108c630?, 0x4c7bf40?})
	/home/prow/go/src/sigs.k8s.io/cluster-api-provider-azure/test/logger.go:39 +0x27
github.com/onsi/gomega/internal.(*Assertion).match(0xc000e9e500, {0x576f648, 0x7980860}, 0x0, {0xc000eb3790, 0x1, 0x1})
	/home/prow/go/pkg/mod/github.com/onsi/[email protected]/internal/assertion.go:106 +0x1f0
github.com/onsi/gomega/internal.(*Assertion).NotTo(0xc000e9e500, {0x576f648, 0x7980860}, {0xc000eb3790, 0x1, 0x1})
	/home/prow/go/pkg/mod/github.com/onsi/[email protected]/internal/assertion.go:74 +0xad
sigs.k8s.io/cluster-api/test/framework.DumpAllResources({0x5788d70, 0x7980860}, {{0x7fe1bc396a90, 0xc000e14900}, {0x0, 0x0}, {0x0, 0x0}, {0x7fff5e82b281, 0x7}, ...})
	/home/prow/go/pkg/mod/sigs.k8s.io/cluster-api/[email protected]/framework/alltypes_helpers.go:132 +0x1c3
main.collectManagementClusterLogs(0xc0003fc2b0, {0xc000635320, 0x2e}, 0xc000365520, {0xc0006352f0, 0x2c})
	/home/prow/go/src/sigs.k8s.io/cluster-api-provider-azure/test/logger.go:96 +0x38a
main.main()
	/home/prow/go/src/sigs.k8s.io/cluster-api-provider-azure/test/logger.go:78 +0x5f7

@k8s-ci-robot
Copy link
Contributor

@nawazkh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-azure-test 1f928a3 link true /test pull-cluster-api-provider-azure-test
pull-cluster-api-provider-azure-apidiff 1f928a3 link false /test pull-cluster-api-provider-azure-apidiff
pull-cluster-api-provider-azure-conformance-with-ci-artifacts-dra 1f928a3 link false /test pull-cluster-api-provider-azure-conformance-with-ci-artifacts-dra
pull-cluster-api-provider-azure-e2e-aks 1f928a3 link true /test pull-cluster-api-provider-azure-e2e-aks
pull-cluster-api-provider-azure-ci-entrypoint 1f928a3 link true /test pull-cluster-api-provider-azure-ci-entrypoint
pull-cluster-api-provider-azure-e2e 1f928a3 link true /test pull-cluster-api-provider-azure-e2e
pull-cluster-api-provider-azure-conformance-dual-stack-with-ci-artifacts 1f928a3 link false /test pull-cluster-api-provider-azure-conformance-dual-stack-with-ci-artifacts
pull-cluster-api-provider-azure-capi-e2e 1f928a3 link false /test pull-cluster-api-provider-azure-capi-e2e
pull-cluster-api-provider-azure-apiversion-upgrade 1f928a3 link true /test pull-cluster-api-provider-azure-apiversion-upgrade
pull-cluster-api-provider-azure-conformance 1f928a3 link false /test pull-cluster-api-provider-azure-conformance
pull-cluster-api-provider-azure-conformance-with-ci-artifacts 1f928a3 link false /test pull-cluster-api-provider-azure-conformance-with-ci-artifacts
pull-cluster-api-provider-azure-conformance-ipv6-with-ci-artifacts 1f928a3 link false /test pull-cluster-api-provider-azure-conformance-ipv6-with-ci-artifacts
pull-cluster-api-provider-azure-conformance-custom-builds 1f928a3 link false /test pull-cluster-api-provider-azure-conformance-custom-builds

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@tamalsaha tamalsaha mentioned this pull request Apr 14, 2025
4 tasks
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 15, 2025
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@nawazkh
Copy link
Member Author

nawazkh commented Apr 15, 2025

Closing this PR in favor of #5517
/close

@k8s-ci-robot
Copy link
Contributor

@nawazkh: Closed this PR.

In response to this:

Closing this PR in favor of #5517
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@github-project-automation github-project-automation bot moved this from Todo to Done in CAPZ Planning Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants