Bump CAPI to v1.10.0-rc.0 #5517

tamalsaha · 2025-03-26T06:30:37Z

What type of PR is this?

What this PR does / why we need it:
As the title suggests, I am updating k/k libs. Requires Azure/azure-service-operator#4646

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

TODOs:

squashed commits
includes documentation
adds unit tests
cherry-pick candidate

Release note:

NONE

k8s-ci-robot · 2025-03-26T06:30:47Z

Welcome @tamalsaha!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-azure 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-azure has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2025-03-26T06:30:48Z

Hi @tamalsaha. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot · 2025-03-26T06:31:52Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign neolit123 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

nawazkh · 2025-03-26T07:01:26Z

5000+ changes?! 😱

tamalsaha · 2025-03-26T07:13:42Z

Whatever go mod vendor; go mod tidy giveth.

The real change is the fixes needed for the Validator and Defaulter api breakage by the controller-runtime.

nawazkh · 2025-03-26T17:17:24Z

Whatever go mod vendor; go mod tidy giveth.

Thanks for the update! Just an FYI: Cluster API Provider Azure doesn’t vendor its dependencies, we rely on Go modules and our go.mod/go.sum files for dependency management.

tamalsaha · 2025-03-27T01:07:19Z

Removed the vendor folder. PTAL.

Just curious why the vendor folder is not added to the .gitignore.

tamalsaha · 2025-03-27T01:14:08Z

api/v1beta1/azuremachinetemplate_webhook.go


 // ValidateCreate implements webhook.CustomValidator so a webhook will be registered for the type.
-func (r *AzureMachineTemplate) ValidateCreate(_ context.Context, obj runtime.Object) (admission.Warnings, error) {
+func (_ *azureMachineTemplateWebhook) ValidateCreate(_ context.Context, obj runtime.Object) (admission.Warnings, error) {


The code on the left looks suspect. Some lines modify the receiver object, some lines modify the input parameter obj. Now, all lines modify the input parameter.

willie-yao · 2025-03-31T17:51:32Z

/ok-to-test

nawazkh · 2025-03-31T18:15:43Z

Just curious why the vendor folder is not added to the .gitignore.

I did not find a historical reason for this, so I cannot really guess either.
Getting vendor/ ignored via .gitignore will be a welcome change. Please feel free to update gitignore via this PR, although I request you to add it in a separate commit and not squash the commit updating gitignore before merging.

nawazkh · 2025-03-31T18:21:48Z

go.mod

+go 1.23.2

-toolchain go1.22.12
+toolchain go1.24.1


CAPZ's go version updates are driven by CAPI minor updates.
Currently CAPZ main is at CAPI v1.9.x. Once we merge CAPI v1.10.0, we can review this PR (Reference: https://github.com/kubernetes-sigs/cluster-api/blob/release-1.10/go.mod#L3)
/hold

/cc @mboersma @willie-yao @Jont828

nawazkh · 2025-03-31T18:23:25Z

go.mod

 	sigs.k8s.io/yaml v1.4.0 // indirect
 )
+
+replace github.com/Azure/azure-service-operator/v2 => github.com/Azure/azure-service-operator/v2 v2.12.1-0.20250328191251-ba00156bcd68


Sorry I don't fully understand this. Is there a specific reason to be pinning github.com/Azure/azure-service-operator/v2 v1.12.0 to a specific SHA v2.12.1-0.20250328191251-ba00156bcd68 ?

Also, does updating ASO version also require us to update API Versions at CAPZ, @nojnhuh ?

We generally should not be pinning to untagged commits for ASO because we also pull in their YAML manifests and CRDs from tagged releases. I don't think those are available for every commit. The ones from the closest release might work, but we we don't need to be in the business of verifying those things ourselves. Let's wait to update ASO until they tag a release with the new controller-runtime.

The kubebuilder api breakage also affects the ASO repo. This is the first commit where this was fixed.

Azure/azure-service-operator#4646

Once they have a proper tag that should be used. But there is no tag since ASO pr was merged.

Signed-off-by: Tamal Saha <[email protected]>

tamalsaha · 2025-04-14T23:57:41Z

Hello, I see that there are 2 more prs in flight that address this issue? #5563 #5533 . If those prs are going to be merged, I can close this one. If this pr going to be merged, let me know. I am back after kubecon.

k8s-ci-robot · 2025-04-15T00:20:13Z

@tamalsaha: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-cluster-api-provider-azure-verify	`f553c5f`	link	true	`/test pull-cluster-api-provider-azure-verify`
pull-cluster-api-provider-azure-e2e	`f553c5f`	link	true	`/test pull-cluster-api-provider-azure-e2e`
pull-cluster-api-provider-azure-capi-e2e	`f553c5f`	link	false	`/test pull-cluster-api-provider-azure-capi-e2e`
pull-cluster-api-provider-azure-e2e-aks	`f553c5f`	link	true	`/test pull-cluster-api-provider-azure-e2e-aks`
pull-cluster-api-provider-azure-test	`f553c5f`	link	true	`/test pull-cluster-api-provider-azure-test`
pull-cluster-api-provider-azure-apidiff	`f553c5f`	link	false	`/test pull-cluster-api-provider-azure-apidiff`
pull-cluster-api-provider-azure-e2e-workload-upgrade	`f553c5f`	link	false	`/test pull-cluster-api-provider-azure-e2e-workload-upgrade`
pull-cluster-api-provider-azure-ci-entrypoint	`f553c5f`	link	true	`/test pull-cluster-api-provider-azure-ci-entrypoint`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

github-project-automation bot added this to CAPZ Planning Mar 26, 2025

github-project-automation bot moved this to Todo in CAPZ Planning Mar 26, 2025

k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 26, 2025

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 26, 2025

k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 26, 2025

k8s-ci-robot requested review from mboersma and willie-yao March 26, 2025 06:31

tamalsaha force-pushed the k132 branch from 92e1f3f to 44aa045 Compare March 26, 2025 08:06

tamalsaha force-pushed the k132 branch from 44aa045 to c5aa2a5 Compare March 27, 2025 01:06

k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 27, 2025

tamalsaha commented Mar 27, 2025

View reviewed changes

tamalsaha force-pushed the k132 branch 2 times, most recently from 13b70ca to d360b1e Compare March 28, 2025 21:05

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 31, 2025

nawazkh reviewed Mar 31, 2025

View reviewed changes

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 31, 2025

k8s-ci-robot requested a review from Jont828 March 31, 2025 18:22

nawazkh reviewed Mar 31, 2025

View reviewed changes

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 8, 2025

tamalsaha force-pushed the k132 branch from d360b1e to 70f6e27 Compare April 14, 2025 23:47

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 14, 2025

tamalsaha changed the title ~~Update to k8s 1.32 client libs~~ Bump CAPI to v1.10.0-rc.0 Apr 14, 2025

tamalsaha force-pushed the k132 branch from 70f6e27 to a4d665c Compare April 14, 2025 23:50

Bump CAPI to v1.10.0-rc.0

f553c5f

Signed-off-by: Tamal Saha <[email protected]>

tamalsaha force-pushed the k132 branch from a4d665c to f553c5f Compare April 14, 2025 23:52

k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 14, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump CAPI to v1.10.0-rc.0 #5517

Bump CAPI to v1.10.0-rc.0 #5517

tamalsaha commented Mar 26, 2025 •

edited

Loading

k8s-ci-robot commented Mar 26, 2025

k8s-ci-robot commented Mar 26, 2025

k8s-ci-robot commented Mar 26, 2025

nawazkh commented Mar 26, 2025

tamalsaha commented Mar 26, 2025 •

edited

Loading

nawazkh commented Mar 26, 2025

tamalsaha commented Mar 27, 2025

tamalsaha Mar 27, 2025

willie-yao commented Mar 31, 2025

nawazkh commented Mar 31, 2025

nawazkh Mar 31, 2025

nawazkh Mar 31, 2025

nawazkh Mar 31, 2025

nawazkh Mar 31, 2025

nojnhuh Mar 31, 2025

tamalsaha Apr 14, 2025 •

edited

Loading

tamalsaha commented Apr 14, 2025

k8s-ci-robot commented Apr 15, 2025

Bump CAPI to v1.10.0-rc.0 #5517

Are you sure you want to change the base?

Bump CAPI to v1.10.0-rc.0 #5517

Conversation

tamalsaha commented Mar 26, 2025 • edited Loading

k8s-ci-robot commented Mar 26, 2025

k8s-ci-robot commented Mar 26, 2025

k8s-ci-robot commented Mar 26, 2025

nawazkh commented Mar 26, 2025

tamalsaha commented Mar 26, 2025 • edited Loading

nawazkh commented Mar 26, 2025

tamalsaha commented Mar 27, 2025

tamalsaha Mar 27, 2025

Choose a reason for hiding this comment

willie-yao commented Mar 31, 2025

nawazkh commented Mar 31, 2025

nawazkh Mar 31, 2025

Choose a reason for hiding this comment

nawazkh Mar 31, 2025

Choose a reason for hiding this comment

nawazkh Mar 31, 2025

Choose a reason for hiding this comment

nawazkh Mar 31, 2025

Choose a reason for hiding this comment

nojnhuh Mar 31, 2025

Choose a reason for hiding this comment

tamalsaha Apr 14, 2025 • edited Loading

Choose a reason for hiding this comment

tamalsaha commented Apr 14, 2025

k8s-ci-robot commented Apr 15, 2025

tamalsaha commented Mar 26, 2025 •

edited

Loading

tamalsaha commented Mar 26, 2025 •

edited

Loading

tamalsaha Apr 14, 2025 •

edited

Loading