Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add support for specifying pod's routes by subnet's .spec.routes #4973

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions charts/kube-ovn/templates/kube-ovn-crd.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2461,6 +2461,24 @@ spec:
type: array
items:
type: string
routes:
description: |
Routes is a list of route rules for the pods which are in the subnet.
If specified, the routes will be added/replaced to the pod's network namespace.
type: array
items:
type: object
properties:
dst:
type: string
format: cidr
gw:
type: string
anyOf:
- format: ipv4
- format: ipv6
required:
- gw
gatewayType:
type: string
allowSubnets:
Expand Down
18 changes: 18 additions & 0 deletions dist/images/install.sh
Original file line number Diff line number Diff line change
Expand Up @@ -2712,6 +2712,24 @@ spec:
type: array
items:
type: string
routes:
description: |
Routes is a list of route rules for the pods which are in the subnet.
If specified, the routes will be added/replaced to the pod's network namespace.
type: array
items:
type: object
properties:
dst:
type: string
format: cidr
gw:
type: string
anyOf:
- format: ipv4
- format: ipv6
required:
- gw
gatewayType:
type: string
allowSubnets:
Expand Down
7 changes: 7 additions & 0 deletions pkg/apis/kubeovn/v1/subnet.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ import (
corev1 "k8s.io/api/core/v1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/klog/v2"

"github.com/kubeovn/kube-ovn/pkg/request"
)

const (
Expand Down Expand Up @@ -49,6 +51,11 @@ type SubnetSpec struct {
ExcludeIps []string `json:"excludeIps,omitempty"`
Provider string `json:"provider,omitempty"`

// Routes is a list of route rules for the pods which are in the subnet.
// If specified, the routes will be added/replaced to the pod's network namespace.
// +optional
Routes []request.Route `json:"routes,omitempty"`

GatewayType string `json:"gatewayType,omitempty"`
GatewayNode string `json:"gatewayNode"`
NatOutgoing bool `json:"natOutgoing"`
Expand Down
23 changes: 11 additions & 12 deletions pkg/daemon/handler.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ import (
"fmt"
"net"
"net/http"
"slices"
"strconv"
"strings"
"time"

"github.com/emicklei/go-restful/v3"
Expand Down Expand Up @@ -226,19 +226,18 @@ func (csh cniServerHandler) handleAdd(req *restful.Request, resp *restful.Respon
return
}

var mtu int
routes = append(podRequest.Routes, routes...)
if strings.HasSuffix(podRequest.Provider, util.OvnProvider) && subnet != "" {
podSubnet, err := csh.Controller.subnetsLister.Get(subnet)
if err != nil {
errMsg := fmt.Errorf("failed to get subnet %s: %w", subnet, err)
klog.Error(errMsg)
if err = resp.WriteHeaderAndEntity(http.StatusInternalServerError, request.CniResponse{Err: errMsg.Error()}); err != nil {
klog.Errorf("failed to write response: %v", err)
}
return
if podSubnet, err = csh.Controller.subnetsLister.Get(subnet); err != nil {
errMsg := fmt.Errorf("failed to get subnet %q: %w", subnet, err)
klog.Error(errMsg)
if err = resp.WriteHeaderAndEntity(http.StatusInternalServerError, request.CniResponse{Err: errMsg.Error()}); err != nil {
klog.Errorf("failed to write response: %v", err)
}
return
}

var mtu int
routes = slices.Concat(podRequest.Routes, podSubnet.Spec.Routes, routes)
if util.IsOvnProvider(podRequest.Provider) {
if podSubnet.Status.U2OInterconnectionIP == "" && podSubnet.Spec.U2OInterconnection {
errMsg := fmt.Errorf("failed to generate u2o ip on subnet %s", podSubnet.Name)
klog.Error(errMsg)
Expand Down
69 changes: 69 additions & 0 deletions test/e2e/kube-ovn/subnet/subnet.go
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
"time"

corev1 "k8s.io/api/core/v1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
clientset "k8s.io/client-go/kubernetes"
e2enode "k8s.io/kubernetes/test/e2e/framework/node"
e2epodoutput "k8s.io/kubernetes/test/e2e/framework/pod/output"
Expand All @@ -21,6 +22,7 @@
"github.com/onsi/gomega"

apiv1 "github.com/kubeovn/kube-ovn/pkg/apis/kubeovn/v1"
"github.com/kubeovn/kube-ovn/pkg/request"
"github.com/kubeovn/kube-ovn/pkg/util"
"github.com/kubeovn/kube-ovn/test/e2e/framework"
"github.com/kubeovn/kube-ovn/test/e2e/framework/docker"
Expand Down Expand Up @@ -289,6 +291,73 @@
}
})

framework.ConformanceIt(`should be able to configure pod routes by subnet's ".spec.routes" field`, func() {
subnet = framework.MakeSubnet(subnetName, "", cidr, "", "", "", nil, nil, nil)
ginkgo.By("Creating subnet " + subnetName + " with cidr " + subnet.Spec.CIDRBlock)
subnet = subnetClient.CreateSync(subnet)

ginkgo.By(`Constructing specified routes by subnet's ".spec.routes" field`)
var routeDst string
for i := 0; i < 3; i++ {
routeDst = framework.RandomCIDR(f.ClusterIPFamily)
if routeDst != subnet.Spec.CIDRBlock {
break
}
}
framework.ExpectNotEqual(routeDst, subnet.Spec.CIDRBlock)
routeGw := framework.RandomIPs(subnet.Spec.CIDRBlock, "", 1)
ipv4Gateway, ipv6Gateway := util.SplitStringIP(subnet.Spec.Gateway)
ipv4RouteDst, ipv6RouteDst := util.SplitStringIP(routeDst)
ipv4RouteGw, ipv6RouteGw := util.SplitStringIP(routeGw)
routes := make([]request.Route, 0, 4)
if f.HasIPv4() {
routes = append(routes, request.Route{Gateway: ipv4RouteGw})
routes = append(routes, request.Route{Destination: ipv4RouteDst, Gateway: ipv4Gateway})

}
if f.HasIPv6() {
routes = append(routes, request.Route{Gateway: ipv6RouteGw})
routes = append(routes, request.Route{Destination: ipv6RouteDst, Gateway: ipv6Gateway})
}

ginkgo.By("Updating subnet " + subnetName + " with routes " + fmt.Sprintf("%v", routes))
subnet.Spec.Routes = routes
subnet = subnetClient.Update(subnet, metav1.UpdateOptions{}, 2*time.Second)

Check failure on line 325 in test/e2e/kube-ovn/subnet/subnet.go

View workflow job for this annotation

GitHub Actions / Kube-OVN Conformance E2E (ipv6, underlay)

It 02/13/25 02:12:34.987

ginkgo.By("Creating pod " + podName)
cmd := []string{"sleep", "infinity"}
annotations := map[string]string{util.LogicalSwitchAnnotation: subnetName}
pod := framework.MakePrivilegedPod(namespaceName, podName, nil, annotations, f.KubeOVNImage, cmd, nil)
_ = podClient.CreateSync(pod)

ginkgo.By("Retrieving pod routes")
podRoutes, err := iproute.RouteShow("", "", func(cmd ...string) ([]byte, []byte, error) {
return framework.KubectlExec(namespaceName, podName, cmd...)
})
framework.ExpectNoError(err)

ginkgo.By("Validating pod routes")
actualRoutes := make([]request.Route, 0, len(podRoutes))
for _, r := range podRoutes {
if r.Gateway != "" || r.Dst != "" {
actualRoutes = append(actualRoutes, request.Route{Destination: r.Dst, Gateway: r.Gateway})
}
}
ipv4CIDR, ipv6CIDR := util.SplitStringIP(subnet.Spec.CIDRBlock)
if f.HasIPv4() {
framework.ExpectContainElement(actualRoutes, request.Route{Destination: ipv4CIDR})
framework.ExpectNotContainElement(actualRoutes, request.Route{Destination: "default", Gateway: ipv4Gateway})
framework.ExpectContainElement(actualRoutes, request.Route{Destination: "default", Gateway: ipv4RouteGw})
framework.ExpectContainElement(actualRoutes, request.Route{Destination: ipv4RouteDst, Gateway: ipv4Gateway})
}
if f.HasIPv6() {
framework.ExpectContainElement(actualRoutes, request.Route{Destination: ipv6CIDR})
framework.ExpectNotContainElement(actualRoutes, request.Route{Destination: "default", Gateway: ipv6Gateway})
framework.ExpectContainElement(actualRoutes, request.Route{Destination: "default", Gateway: ipv6RouteGw})
framework.ExpectContainElement(actualRoutes, request.Route{Destination: ipv6RouteDst, Gateway: ipv6Gateway})
}
})

framework.ConformanceIt("should create subnet with centralized gateway", func() {
ginkgo.By("Getting nodes")
nodes, err := e2enode.GetReadySchedulableNodes(context.Background(), cs)
Expand Down
Loading