Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add support for specifying pod's routes by subnet's .spec.routes #4973

Closed
wants to merge 1 commit into from

Conversation

zhangzujian
Copy link
Member

Pull Request

What type of this PR

Examples of user facing changes:

  • Features
  • Bug fixes
  • Docs
  • Tests

Which issue(s) this PR fixes

Closes #4966

@coveralls
Copy link

coveralls commented Feb 8, 2025

Pull Request Test Coverage Report for Build 13298779618

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 9 (0.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage remained the same at 22.329%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/daemon/handler.go 0 9 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/daemon/handler.go 1 0.0%
Totals Coverage Status
Change from base Build 13298743148: 0.0%
Covered Lines: 10382
Relevant Lines: 46495

💛 - Coveralls

@zhangzujian zhangzujian force-pushed the subnet-routes branch 2 times, most recently from e9f4c26 to 9cfb0ad Compare February 8, 2025 07:23
@zhangzujian zhangzujian marked this pull request as ready for review February 8, 2025 07:27
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. feature New network feature labels Feb 8, 2025
@zhangzujian zhangzujian requested a review from oilbeater February 8, 2025 09:27
@zhangzujian zhangzujian deleted the subnet-routes branch February 17, 2025 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New network feature size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Provide option to disable default gateway creation or set handling precedence
2 participants