Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include tests in sdist #2290

Closed
wants to merge 1 commit into from
Closed

Conversation

cjwatson
Copy link
Contributor

Including tests would make it easier for downstream distributors (e.g. Debian) to ensure that changes to other dependencies haven't broken this package.

Including tests would make it easier for downstream distributors (e.g.
Debian) to ensure that changes to other dependencies haven't broken this
package.
@cjwatson cjwatson mentioned this pull request Jan 30, 2025
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (dd92cd0) to head (9f0d5d1).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #2290   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           38        38           
  Lines         4307      4307           
  Branches       994       994           
=========================================
  Hits          4307      4307           
Flag Coverage Δ
unittests 99.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Jan 31, 2025

CodSpeed Performance Report

Merging #2290 will not alter performance

Comparing cjwatson:tests-sdist (9f0d5d1) with main (dd92cd0)

Summary

✅ 31 untouched benchmarks

@gaborbernat
Copy link
Collaborator

We moved over to hatchling that should have fixed this.

@gaborbernat gaborbernat closed this Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants