Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support isort 6 #2289

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Support isort 6 #2289

wants to merge 2 commits into from

Conversation

cjwatson
Copy link

The breaking changes in isort 6 are just to remove support for Python 3.8 (see https://github.com/PyCQA/isort/releases), so there's no need for this project to treat it differently from isort 5.

The breaking changes in isort 6 are just to remove support for Python
3.8 (see https://github.com/PyCQA/isort/releases), so there's no need
for this project to treat it differently from isort 5.
@cjwatson
Copy link
Author

I see the pre-commit failure, but it seems to be entirely due to running with the fact that the check now runs with poetry-core 2.0.1, rather than anything to do with my changes. Do you want me to include the results of running poetry lock anyway?

@cjwatson
Copy link
Author

Hm, since pre-commit passed in #2290, I guess I have no choice. I've updated poetry.lock.

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.76%. Comparing base (dd92cd0) to head (2bf0467).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##              main    #2289      +/-   ##
===========================================
- Coverage   100.00%   99.76%   -0.24%     
===========================================
  Files           38       38              
  Lines         4307     4307              
  Branches       994      994              
===========================================
- Hits          4307     4297      -10     
- Misses           0        6       +6     
- Partials         0        4       +4     
Flag Coverage Δ
unittests 99.48% <ø> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Jan 31, 2025

CodSpeed Performance Report

Merging #2289 will not alter performance

Comparing cjwatson:isort-6 (2bf0467) with main (dd92cd0)

Summary

✅ 31 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant