-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add model-based test for data entry #949
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #949 +/- ##
=======================================
Coverage 89.80% 89.80%
=======================================
Files 238 238
Lines 12561 12561
Branches 1281 1281
=======================================
Hits 11281 11281
Misses 1191 1191
Partials 89 89 ☔ View full report in Codecov by Sentry. |
Sigrid maintainability feedback💭️ You did not change any files that are measured by Sigrid |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I understand what's going on and I verified that the tests are actually run. I've sampled some tests through the Playwright UI to see that the tests are sane.
I'm experiencing some flakiness testing locally, but I'm convinced that this is unrelated to this PR
On Wednesday 5 Feb after standup @oliver3 and I will discuss if there's a way to check only once there's code for all events and steps in the state machine. |
@jschuurk-kr this branch has a merge conflict, could you resolve that? lgtm otherwise |
Scope
Questions
It would be nice to only check once that the events and states in the machine match the events and states in the test. However, the events and states in the test require the Playwright fixtures
page
,pollingStation
,election
. So I don't think there's a way to do this. If you know of a solution, please share!I made the model-based tests part of the e2e tests. So this PR adds 3 x 23 tests to the e2e tests. Part of issue #898 Change PollingStation.test.tsx to Playwright tests is to check the coverage of the e2e tests, because I think there currently is some overlap between the existing e2e tests, the model-based tests in this PR, and the tests in PollingStation.test.tsx.