Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add model-based test for data entry #933

Closed
1 of 4 tasks
jschuurk-kr opened this issue Jan 30, 2025 · 0 comments · Fixed by #949
Closed
1 of 4 tasks

Add model-based test for data entry #933

jschuurk-kr opened this issue Jan 30, 2025 · 0 comments · Fixed by #949
Assignees
Labels
tests Issues or pull requests that relate to tests

Comments

@jschuurk-kr
Copy link
Contributor

jschuurk-kr commented Jan 30, 2025

Follow-up of PR #840: spike: model-based testing of data entry forms with xstate

In scope

  • add model-based test from spike
  • improve code: helper functions (e.g. check values of voters and votes fields), split up states and events in test into multiple objects, extend page objects
  • write code that checks if states and actions from machine are present in test and vice-versa
    • Currently there's no check that the test contains code for both all states and all events. The tests will just run. In case of an event without code, they will very likely fail; in case of a state without code the test will just pass. For the states in the machine there is a check that each state is defined.
  • decide what from "Not in scope" needs to be done and create issues for those tasks

Not in scope

  • data entry that results in error
  • data entry that results in warning
  • closing save/discard modal
@jschuurk-kr jschuurk-kr self-assigned this Jan 30, 2025
@jschuurk-kr jschuurk-kr converted this from a draft issue Jan 30, 2025
@jschuurk-kr jschuurk-kr added the tests Issues or pull requests that relate to tests label Jan 30, 2025
@jschuurk-kr jschuurk-kr changed the title Add model-bases test for data entry Add model-based test for data entry Jan 30, 2025
@jschuurk-kr jschuurk-kr linked a pull request Feb 3, 2025 that will close this issue
@github-project-automation github-project-automation bot moved this from In Progress to Done in Abacus Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Issues or pull requests that relate to tests
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant