-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement custom radiobuttons + choicelist component #435
Implement custom radiobuttons + choicelist component #435
Conversation
…lt-in behaviour for the radio groups
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on MacOS (Chrome, Safari, Firefox):
- ✅ styling of radio's looks okay (all states)
- ✅ styling and behavior of checkbox is still ok. (can't retest a group of checkboxes though, because we don't have that yet)
- ❌ when hovering, the label has a hand/pointer cursor, the radio has a default cursor. Could we use pointer for both?
- ❌ padding/margin left of radio's should be removed; radio's should left align with elements above and below it
- ❌ when using tab to navigate through the page, it is now impossible to continu to the submit button from the choice group. Please compare to vanilla html form, behavior should be same. (might be fixed in Navigating form sections and focus state #305?)
- ❌ having to click a radio twice is not expected behavior. Don't know exactly when/how this happens, but it should not. Clicking a radiobutton or it's label should immediately change it's state to checked.
Fixed the cursor, padding and margin in ee2a9bb |
…trolled input Cleaned up code some more and added comments
LGTM now @Lionqueen94! Let's make sure to check the tab/navigation issue after merging this to main |
Description
What to test
Is it ok that you sometimes have to click a radio button twice to check it (is this normal?)@jorisleker