Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement custom radiobuttons + choicelist component #371

Closed
4 tasks done
jorisleker opened this issue Sep 24, 2024 · 0 comments · Fixed by #435
Closed
4 tasks done

Implement custom radiobuttons + choicelist component #371

jorisleker opened this issue Sep 24, 2024 · 0 comments · Fixed by #435
Assignees
Labels
accessibility frontend Issues or pull requests that relate to the frontend ux debt

Comments

@jorisleker
Copy link
Contributor

jorisleker commented Sep 24, 2024

In #292 and #357 we implemented custom styling for checkboxes. Mainly to be able to show an error/invalid state. We still use default browser radio buttons, which leads to some design inconsistencies and issues with styling of focus states.

In Figma, all instances of radio groups have been replaced by a new custom styled radio-component.
Part of this ticket is to also implement the parent/container element of the checkbox/radio input's: the choice list, which defines spacing between and around groups of checkboxes/radio's.

Links to design

  1. Radio component
  2. Choice list component
  3. Instance of choice list as currently used

Scope of ticket:

  • implement custom styling of radio button
  • implement choice list
  • check codebase for places where input type=radio and input type=checkbox are used and implement custom element + choicelist container (radio: in recounted step, checkbox: used to accept warnings).
  • make sure radio group behaviour works
@github-project-automation github-project-automation bot moved this to Options in Abacus Sep 24, 2024
@praseodym praseodym moved this from Options to Current in Abacus Sep 30, 2024
@Lionqueen94 Lionqueen94 moved this from Current to In Progress in Abacus Oct 1, 2024
@Lionqueen94 Lionqueen94 linked a pull request Oct 8, 2024 that will close this issue
6 tasks
@Lionqueen94 Lionqueen94 added the frontend Issues or pull requests that relate to the frontend label Oct 8, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Abacus Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility frontend Issues or pull requests that relate to the frontend ux debt
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants