Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polling station data submit controller and hooks #142

Merged
merged 58 commits into from
Jul 16, 2024
Merged

Polling station data submit controller and hooks #142

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
58 commits
Select commit Hold shift + click to select a range
cc90ec5
add political group mock
lkleuver Jul 9, 2024
3ebe4c2
working forms with broken tests
lkleuver Jul 9, 2024
c33b8af
removed gen from ignored
lkleuver Jul 9, 2024
223f933
Merge branch 'main' into frontend.data-request-and-form-state
Lionqueen94 Jul 9, 2024
64a9f7a
Re-added maxLength on CandidateVotes fields
Lionqueen94 Jul 9, 2024
353e25f
fix CanidatesVotesForm
lkleuver Jul 10, 2024
4b5c329
fix election details
lkleuver Jul 10, 2024
2184ca6
Merge branch 'main' into frontend.data-request-and-form-state
Lionqueen94 Jul 11, 2024
66c2dae
Improved imports
Lionqueen94 Jul 11, 2024
df8d5dd
fix mock validation result strings
lkleuver Jul 11, 2024
09ea3fb
remove log statements
lkleuver Jul 11, 2024
e04c330
fix spelling
lkleuver Jul 11, 2024
ec21565
Fixed pollingStationId showing properly in PollingStationLayout
Lionqueen94 Jul 11, 2024
8deff2b
change to override
lkleuver Jul 11, 2024
98a2756
Fixed political group list total not being remembered
Lionqueen94 Jul 11, 2024
68a937e
Merge remote-tracking branch 'origin/frontend.data-request-and-form-s…
Lionqueen94 Jul 11, 2024
69448d1
remove success feedback
lkleuver Jul 11, 2024
2f0036a
Fixed political group list total being null on currently saved list
Lionqueen94 Jul 11, 2024
d1d5849
Merge remote-tracking branch 'origin/frontend.data-request-and-form-s…
Lionqueen94 Jul 11, 2024
95bf160
Cleaned up some imports and useDifferences code
Lionqueen94 Jul 11, 2024
e413858
fix tests to feedback content
lkleuver Jul 11, 2024
181adf8
fix mismatch
lkleuver Jul 11, 2024
e988b11
DifferencesForm is now using useDifferences, nb: no validation implem…
Lionqueen94 Jul 11, 2024
540aa73
Added some tests, 2 fail due to re-ordering of voters_count and votes…
Lionqueen94 Jul 11, 2024
f0a719f
Merge branch 'main' into frontend.data-request-and-form-state
Lionqueen94 Jul 11, 2024
2bad3de
fix errors for political groups
lkleuver Jul 11, 2024
0350dfb
replaces getBodyObject with getUrlMethodAndBody
jschuurk-kr Jul 12, 2024
38b1683
adds first basic implemenetation for VotersAndVotesForms error messag…
jschuurk-kr Jul 12, 2024
d23d60e
updates CandidatesVotesForm to not show warnings when there is an error
jschuurk-kr Jul 12, 2024
41c9621
changes body of an overrideOnce from string to object
jschuurk-kr Jul 12, 2024
d125713
add errors and warnings to CandidateVotesForm
lkleuver Jul 12, 2024
cbc1ad6
fixes CandidatesVotesForm request body test, still needs refactoring
jschuurk-kr Jul 12, 2024
3aa49bd
fix test ids
lkleuver Jul 12, 2024
ac6428e
change name to id
lkleuver Jul 12, 2024
0e2ad76
fixes differences api request test by doing object comparison
jschuurk-kr Jul 12, 2024
edbdffd
add id to Row
lkleuver Jul 12, 2024
47626f4
adds prefix to Row id to prevent duplicate ids
jschuurk-kr Jul 15, 2024
010044c
adds VotersAndVotesForm test for invalid value
jschuurk-kr Jul 15, 2024
437a32a
adds test for F.12 IncorrectTotal Votes
jschuurk-kr Jul 15, 2024
059a74f
adds test W.21 AboveThreshold blank votes
jschuurk-kr Jul 15, 2024
ffc34ad
adds tests: W22 threshold invalid votes, W27 equal input; fixes varia…
jschuurk-kr Jul 15, 2024
2430d8d
adds VotersAndVotesForm test for error response with unknown fields
jschuurk-kr Jul 15, 2024
6b54087
changes VotersAndVotesForm test for error response with unknown field…
jschuurk-kr Jul 15, 2024
bf86845
fixes comment in VotersAndVotesForm test with unknown fields
jschuurk-kr Jul 15, 2024
1cccf3d
removed commented blocks
lkleuver Jul 15, 2024
9a73ce7
add tests
lkleuver Jul 15, 2024
103d233
fix indeces are number - 1
lkleuver Jul 15, 2024
d84d27d
makes usage of (React)TestingLibrary consistent for VotersAndVotesFor…
jschuurk-kr Jul 15, 2024
47b23f0
makes usage of (React)TestingLibrary consistent for Differences tests
jschuurk-kr Jul 15, 2024
42cd324
makes usage of (React)TestingLibrary consistent for CandidatesVotes t…
jschuurk-kr Jul 15, 2024
4d3a795
makes tests structure across Forms tests consistent
jschuurk-kr Jul 15, 2024
d6f6852
makes variable names for result and feedback more consistent in forms…
jschuurk-kr Jul 15, 2024
15c2be1
makes tests structure across Forms tests consistent (again)
jschuurk-kr Jul 15, 2024
e514902
updates DifferencesForm to use extracted useErrorsAndWarnings
jschuurk-kr Jul 15, 2024
c207e29
remove unused code
lkleuver Jul 15, 2024
9eedab0
adds tests for Candidates and Votes Forms to show warning
jschuurk-kr Jul 16, 2024
001f168
adds InvalidValue error test for CandidatesVotesForm
jschuurk-kr Jul 16, 2024
b67f6a6
removes commented-out line
jschuurk-kr Jul 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion frontend/.eslintrc.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ module.exports = {
"plugin:jsx-a11y/recommended",
"prettier",
],
ignorePatterns: ["dist", ".eslintrc.cjs", "!.ladle/", "gen"],
ignorePatterns: ["dist", ".eslintrc.cjs", "!.ladle/"],
parser: "@typescript-eslint/parser",
plugins: ["react-refresh", "jsx-a11y", "prettier", "@typescript-eslint"],
rules: {
Expand Down
Loading