Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polling station data submit controller and hooks #142

Merged
merged 58 commits into from
Jul 16, 2024

Conversation

lkleuver
Copy link
Contributor

@lkleuver lkleuver commented Jul 9, 2024

submitting the complete data request for pollingstation for each form section by introducing a form controller provider managing the complete state and hooks for working with individual form sections.

@lkleuver lkleuver marked this pull request as ready for review July 10, 2024 14:14
@praseodym praseodym added the frontend Issues or pull requests that relate to the frontend label Jul 11, 2024
@jschuurk-kr
Copy link
Contributor

Can we change the path for the VotersAndVotesPage route from numbers to voters-and-votes?

@lkleuver
Copy link
Contributor Author

Can we change the path for the VotersAndVotesPage route from numbers to voters-and-votes?

definitely, lets leave this out of scope and perhaps discuss all paths and their names?

@Lionqueen94
Copy link
Contributor

Lionqueen94 commented Jul 11, 2024

@lkleuver and I just discussed that I will add the connection to the formcontroller in the next issue I'll work on. The useDifferences.ts I already added, but it's not yet used in DifferencesForm.

frontend/lib/api/election/ElectionProvider.tsx Outdated Show resolved Hide resolved
frontend/lib/api-mocks/index.ts Outdated Show resolved Hide resolved
@jorisleker
Copy link
Contributor

jorisleker commented Jul 16, 2024

Not sure wether these are in scope for this ticket. If not: happy to add them to the design debt ticket.

  • The 'incorrect totals' error on a political group should not show an error icon in any of the inputs (all of them could be wrong, not just the total)
Scherm­afbeelding 2024-07-16 om 14 33 19
  • There should be a spacer before the input for the list-totals, that's lacking. Also, there should not be a bottom border nor a background on the totals row. (see design below)
Scherm­afbeelding 2024-07-16 om 14 37 10

@lkleuver
Copy link
Contributor Author

Not sure wether these are in scope for this ticket. If not: happy to add them to the design debt ticket.

  • The 'incorrect totals' error on a political group should not show an error icon in any of the inputs (all of them could be wrong, not just the total)
Scherm­afbeelding 2024-07-16 om 14 33 19 * [ ] There should be a spacer before the input for the list-totals, that's lacking. Also, there should not be a bottom border nor a background on the totals row. (see design below) Scherm­afbeelding 2024-07-16 om 14 37 10

Design debt sounds good. Can you add?
Need to figure out how to make "special cases" for this.

@lkleuver lkleuver enabled auto-merge July 16, 2024 12:42
@jschuurk-kr
Copy link
Contributor

@lkleuver @jorisleker Behavior of the error/warning icons is in scope of #99 Epic: refine validation, issue Frontend: implement validation copy using unique codes #136. So best to add any comments about the icons there.

@lkleuver lkleuver added this pull request to the merge queue Jul 16, 2024
Merged via the queue into main with commit 14641ba Jul 16, 2024
3 checks passed
@lkleuver lkleuver deleted the frontend.data-request-and-form-state branch July 16, 2024 13:07
@praseodym praseodym linked an issue Jul 16, 2024 that may be closed by this pull request
@Lionqueen94
Copy link
Contributor

Not sure wether these are in scope for this ticket. If not: happy to add them to the design debt ticket.

* [x]  ~The 'incorrect totals' error on a political group should **not** show an error icon in any of the inputs (all of them could be wrong, not just the total)~
Scherm­afbeelding 2024-07-16 om 14 33 19
* [ ]  There should be a spacer before the input for the list-totals, that's lacking. Also, there should not be a bottom border nor a background on the totals row. (see design below)
Scherm­afbeelding 2024-07-16 om 14 37 10

I had implemented the latter a couple of weeks ago, apparently it was undone 😢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Issues or pull requests that relate to the frontend
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Save votes for candidates to backend
5 participants