Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Radio/checkbox: Include description in label, set correct label styling #1031

Conversation

oliver3
Copy link
Contributor

@oliver3 oliver3 commented Feb 13, 2025

Closes #1002

This change is for all radio buttons and checkboxes in the application, for example:

@oliver3 oliver3 added the frontend Issues or pull requests that relate to the frontend label Feb 13, 2025
@oliver3 oliver3 self-assigned this Feb 13, 2025
@oliver3 oliver3 linked an issue Feb 13, 2025 that may be closed by this pull request
Copy link

github-actions bot commented Feb 13, 2025

Sigrid maintainability feedback

✅ You wrote maintainable code and achieved your objective of 3.5 stars

Show details

Sigrid compared your code against the baseline of 2025-02-17.

👍 What went well?

You fixed or improved 0 refactoring candidates.

👎 What could be better?

You did not introduce any technical debt during your changes, great job!

📚 Remaining technical debt

1 refactoring candidates didn't get better or worse, but are still present in the code you touched.

View this system in Sigrid to explore your technical debt

⭐️ Sigrid ratings

System property System on 2025-02-17 Before changes New/changed code
Volume 5.2 N/A N/A
Duplication 4.3 5.5 5.5
Unit Size 2.4 5.5 5.5
Unit Complexity 3.4 N/A N/A
Unit Interfacing 3.0 N/A N/A
Module Coupling 4.0 N/A N/A
Component Independence 2.8 N/A N/A
Component Entanglement 3.7 N/A N/A
Maintainability 3.6 5.5 5.5

💬 Did you find this feedback helpful?

We would like to know your thoughts to make Sigrid better.
Your username will remain confidential throughout the process.


View this system in Sigrid

Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.26%. Comparing base (126ba15) to head (f9c077e).
Report is 9 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1031      +/-   ##
==========================================
+ Coverage   90.19%   90.26%   +0.07%     
==========================================
  Files         249      249              
  Lines       13090    13181      +91     
  Branches     1338     1341       +3     
==========================================
+ Hits        11806    11898      +92     
+ Misses       1190     1187       -3     
- Partials       94       96       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jorisleker
jorisleker previously approved these changes Feb 13, 2025
@praseodym praseodym added this pull request to the merge queue Feb 17, 2025
Merged via the queue into main with commit 75999d8 Feb 17, 2025
21 checks passed
@praseodym praseodym deleted the 1002-choicelistradio-should-have-clickable-hint-and-correct-label-styling branch February 17, 2025 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Issues or pull requests that relate to the frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ChoiceList.Radio should have clickable hint and correct label styling
4 participants