Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ChoiceList.Radio should have clickable hint and correct label styling #1002

Open
oliver3 opened this issue Feb 10, 2025 · 2 comments · May be fixed by #1031
Open

ChoiceList.Radio should have clickable hint and correct label styling #1002

oliver3 opened this issue Feb 10, 2025 · 2 comments · May be fixed by #1031
Assignees
Labels
frontend Issues or pull requests that relate to the frontend

Comments

@oliver3
Copy link
Contributor

oliver3 commented Feb 10, 2025

Mentioned by @jorisleker in #984 (review) :

  • The name of the role should be bold Edit: font-weight 400 and base-black (see Figma)
  • Extend the label so clicking the role name and/or the description will check the radiobutton
@Lionqueen94
Copy link
Contributor

Make sure the bold is optional, since on other places it should not be bold (polling station create, data entry recounted for example

@oliver3
Copy link
Contributor Author

oliver3 commented Feb 11, 2025

After going through the designs, we noticed some inconsistencies for the font weights in combination with color. We concluded that there should only be one font weight and color for the checkbox and radio labels, which is font-weight 400 with base-black.

The description should still be made clickable by surrounding it with the label tag.

@oliver3 oliver3 changed the title ChoiceList.Radio should have clickable hint and bold label ChoiceList.Radio should have clickable hint and correct label styling Feb 11, 2025
@oliver3 oliver3 self-assigned this Feb 13, 2025
@oliver3 oliver3 moved this from Options to In Progress in Abacus Feb 13, 2025
@oliver3 oliver3 added the frontend Issues or pull requests that relate to the frontend label Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Issues or pull requests that relate to the frontend
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

2 participants