Skip to content

test: bump support collect timeout to 300s #1592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mattiaswal wants to merge 2 commits into
base: main
Choose a base branch
from
Open

test: bump support collect timeout to 300s #1592

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ceaf10
test: ptp: Add debug info to investigate flaky behavior
mattiaswal Aug 21, 2026
9ee42fc
test: bump support collect timeout to 300s
mattiaswal Aug 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/case/misc/support_collect/test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
result = tgtssh.run("sudo support --work-dir /tmp collect --log-sec 2",
stdout=f,
stderr=subprocess.PIPE,
timeout=120)
timeout=300)

if result.returncode != 0:
stderr_output = result.stderr.decode('utf-8') if result.stderr else ""
Expand Down Expand Up @@ -120,7 +120,7 @@
result = tgtssh.run(f"sudo support --work-dir /tmp collect --log-sec 2 --password {test_password}",
stdout=f,
stderr=subprocess.PIPE,
timeout=120)
timeout=300)

if result.returncode != 0:
stderr_output = result.stderr.decode('utf-8') if result.stderr else ""
Expand Down
12 changes: 10 additions & 2 deletions test/infamy/ptp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,11 +84,19 @@ def is_own_gm(target, inst_idx=0):


def has_converged(target, threshold_ns=100_000, inst_idx=0):
"""True when |offset-from-time-transmitter| < threshold_ns."""
"""True when |offset-from-time-transmitter| < threshold_ns.

Prints the offset while unconverged, so a failed until() wait
shows the offset trend in the test log.
"""
off = offset_ns(target, inst_idx)
if off is None:
print(f"{target.name}: no offset-from-time-transmitter")
return False
return abs(off) < threshold_ns
if abs(off) < threshold_ns:
return True
print(f"{target.name}: offset {off} ns, threshold {threshold_ns} ns")
return False


def port_state_dbg(target, port_idx=1, inst_idx=0):
Expand Down