Skip to content

test: bump support collect timeout to 300s - #1592

Open
mattiaswal wants to merge 2 commits into
mainfrom
flaky-support-script
Open

test: bump support collect timeout to 300s#1592
mattiaswal wants to merge 2 commits into
mainfrom
flaky-support-script

Conversation

@mattiaswal

@mattiaswal mattiaswal commented Aug 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

This will most likely fix the support collect test, that is flaky on hardware with a lot of ports.

Description

Checklist

Tick relevant boxes, this PR is-a or has-a:

  • Bugfix
    • Regression tests
    • ChangeLog updates (for next release)
  • Feature
    • YANG model change => revision updated?
    • Regression tests added?
    • ChangeLog updates (for next release)
    • Documentation added?
  • Test changes
    • Checked in changed Readme.adoc (make test-spec)
    • Added new test to group Readme.adoc and yaml file
  • Code style update (formatting, renaming)
  • Refactoring (please detail in commit messages)
  • Build related changes
  • Documentation content changes
    • ChangeLog updated (for major changes)
  • Other (please describe):

@mattiaswal
mattiaswal requested a review from wkz August 21, 2026 07:53
@mattiaswal
test: ptp: Add debug info to investigate flaky behavior
5de69df 
Have been seen failure on hardware `PTP transparent clock (IEEE 802.1AS)`
where it fails on hardware in CI:

Test File: /home/styx/.ghmoon/kernelkit/infix/git/test/case/ptp/transparent_clock/ieee802dot1as.py
Test Cmdl: ['--profile', 'ieee802-dot1as']
2026-08-20 13:25:58 # Starting (2026-08-20 13:25:58)
2026-08-20 13:25:58 # host:    monza
2026-08-20 13:25:58 #     mgmt1:   sw1p3
2026-08-20 13:25:58 #     mgmt2:   sw1p2
2026-08-20 13:25:58 #     mgmt3:   sw1p1
2026-08-20 13:25:58 # gm:      styx3
2026-08-20 13:25:58 #     data:    e3
2026-08-20 13:25:58 #     mgmt:    e28
2026-08-20 13:25:58 # tc:      styx2
2026-08-20 13:25:58 #     uplink:  e4
2026-08-20 13:25:58 #     dnlink:  e3
2026-08-20 13:25:58 #     mgmt:    e28
2026-08-20 13:25:58 # receiver: styx1
2026-08-20 13:25:58 #     data:    e4
2026-08-20 13:25:58 #     mgmt:    e28
2026-08-20 13:25:58 #
2026-08-20 13:25:58 # Waiting for DUTs to become reachable...
2026-08-20 13:25:58 # Probing styx3 on port sw1p3 for IPv6LL mgmt address ...
2026-08-20 13:25:58 # Testing using RESTCONF
2026-08-20 13:25:59 # YANG models downloaded.
2026-08-20 13:26:02 # Waiting for DUTs to become reachable...
2026-08-20 13:26:02 # Probing styx2 on port sw1p2 for IPv6LL mgmt address ...
2026-08-20 13:26:02 # Testing using RESTCONF
2026-08-20 13:26:02 # YANG models downloaded.
2026-08-20 13:26:06 # Waiting for DUTs to become reachable...
2026-08-20 13:26:07 # Probing styx1 on port sw1p1 for IPv6LL mgmt address ...
2026-08-20 13:26:07 # Testing using RESTCONF
2026-08-20 13:26:07 # YANG models downloaded.
2026-08-20 13:26:10 ok 1 - Set up topology and attach to DUTs
2026-08-20 13:26:12 ok 2 - Configure grandmaster (OC, priority1=1, p2p)
2026-08-20 13:26:14 ok 3 - Configure transparent clock (p2p-tc, ieee802-dot1as)
2026-08-20 13:26:15 ok 4 - Configure time receiver (OC, priority1=128, client-only)
2026-08-20 13:26:18 ok 5 - Wait for grandmaster port to become time-transmitter
2026-08-20 13:26:22 ok 6 - Wait for time receiver to reach time-receiver state
2026-08-20 13:26:23 ok 7 - Verify time receiver steps-removed equals 1
2026-08-20 13:31:31 not ok 8 - Wait for time receiver offset to converge
2026-08-20 13:31:31 # Exiting (2026-08-20 13:31:31)
2026-08-20 13:31:31 # Traceback (most recent call last):
2026-08-20 13:31:31 #   File "/home/styx/.ghmoon/kernelkit/infix/git/test/case/ptp/transparent_clock/ieee802dot1as.py", line 173, in
2026-08-20 13:31:31 #     until(lambda: ptp.has_converged(receiver, threshold_ns), attempts=180)
2026-08-20 13:31:31 #   File "/home/styx/.ghmoon/kernelkit/infix/git/test/infamy/util.py", line 55, in until
2026-08-20 13:31:31 #     raise Exception("Expected condition did not materialize")
2026-08-20 13:31:31 # Exception: Expected condition did not materialize
2026-08-20 13:31:31 # 1..8
test error, no plan

Add more debug to be able to investigate it when it occur.

Signed-off-by: Mattias Walström <lazzer@gmail.com>
@mattiaswal
test: bump support collect timeout to 300s
e332139 
The collection scales with port count (three ethtool calls per
interface, incl. SFP EEPROM reads) and log size, and 120s is not
always enough on a 28-port switch at the end of a full test run.

Signed-off-by: Mattias Walström <lazzer@gmail.com>
@mattiaswal
mattiaswal force-pushed the flaky-support-script branch from 69958f7 to e332139 Compare August 21, 2026 11:45
@mattiaswal mattiaswal changed the title test: retry timed out ssh commands test: bump support collect timeout to 300s Aug 21, 2026
wkz
wkz approved these changes Aug 21, 2026
View reviewed changes

@wkz wkz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@troglobit

troglobit commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

Interesting how the flakiness moved from PTP boundary clock (IEEE 802.1AS) to PTP basic (IEEE 802.1AS) ... 🤔

@mattiaswal

mattiaswal commented Aug 23, 2026

Copy link
Copy Markdown
Contributor Author

Interesting how the flakiness moved from PTP boundary clock (IEEE 802.1AS) to PTP basic (IEEE 802.1AS) ... 🤔

Will set Claude on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wkz wkz wkz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mattiaswal @troglobit @wkz