Skip to content

Render generic identifiers as text inputs - #28

Open
masnwilliams wants to merge 2 commits into
mainfrom
hypeship/render-identifiers-as-text
Open

Render generic identifiers as text inputs#28
masnwilliams wants to merge 2 commits into
mainfrom
hypeship/render-identifiers-as-text

Conversation

@masnwilliams

@masnwilliams masnwilliams commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

summary

  • render canonical identifier fields as text inputs regardless of their credential ref
  • preserve combined username, email, and phone labels without browser-native email or telephone validation
  • add regression coverage for email-, username-, and phone-named canonical identifiers

testing

  • bun test
  • bun run build
  • bun run typecheck
  • bun run format:check

release

Includes a patch changeset for @onkernel/managed-auth-react.


Note

Low Risk
Small projection change in managed-auth session normalization with test coverage; no auth or server logic changes.

Overview
Canonical identifier fields are no longer mapped to email or tel discovered types based on ref; they always project to text inputs.

That removes browser-native email/telephone validation on login fields that are meant to accept username, email, or phone in one box (labels like “Mobile number, username, or email” stay as provided by the server). Regression tests in state.test.ts were updated for email-, username-, and phone-named identifiers. A patch changeset ships for @onkernel/managed-auth-react.

Reviewed by Cursor Bugbot for commit 1e56afa. Bugbot is set up for automated code reviews on this repo. Configure here.

@vercel

vercel Bot commented Aug 30, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
managed-auth-react-demo Ready Ready Preview Sep 2, 2026 8:59pm UTC

@masnwilliams
masnwilliams requested review from akxue and dcruzeneil2 and removed request for dcruzeneil2 August 31, 2026 20:38

@akxue akxue left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed — looks good, straightforward fix

  • packages/managed-auth-react/src/session/state.ts:44 — always-text for identifiers is the right default; the ref-sniffing was fragile (substring false positives) and native email/tel validation breaks combined fields. tradeoff noted: pure email/phone fields lose inputmode hints on mobile — worth revisiting smarter inference (ideally server-provided) once there's more signal
  • test coverage pins both removed inference branches (email-ref and phone-ref), and the fixture label reflects the real combined-field case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants