Render managed auth field input modes - #29
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
masnwilliams
changed the base branch from
hypeship/render-identifiers-as-text
to
main
August 31, 2026 22:16
masnwilliams
changed the base branch from
main
to
hypeship/render-identifiers-as-text
August 31, 2026 22:16
masnwilliams
changed the base branch from
hypeship/render-identifiers-as-text
to
main
August 31, 2026 22:39
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 0770c2a. Configure here.
akxue
approved these changes
Sep 1, 2026
akxue
left a comment
There was a problem hiding this comment.
reviewed — lgtm, approve. two non-blockers:
packages/managed-auth-react/src/components/UnifiedAuthForm.test.ts— worth adding a test pinning the ordering:input_modeshould take precedence over the ref-based username heuristic (e.g.ref: "username"+input_mode: "email"→"email"), so the precedence is deliberate rather than emergentpackages/managed-auth-react/src/session/state.ts:68— nit:...(field.input_mode ? { input_mode: field.input_mode } : {})can just beinput_mode: field.input_modesince the prop is already optional
masnwilliams
force-pushed
the
hypeship/render-field-input-mode
branch
from
September 15, 2026 00:23
a157e0b to
a5b00b0
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

summary
input_modevalues in the existing UI modelinputModeprop while keeping identifier inputs astype="text"dependencies
testing
bun testbun run buildbun run typecheckbun run format:checkNote
Low Risk
UI and autofill hinting only; behavior is covered by new unit tests and remains backward compatible when API omits input_mode.
Overview
Adds optional canonical
input_mode(text|email|tel|numeric) on managed-auth fields, carries it through session normalization intoDiscoveredField, and wires it to ReactinputModeonUnifiedAuthForminputs while identifier fields staytype="text"so browsers do not apply email/tel format validation.getAutocompletenow usesinput_modefor dedicated email/tel autofill, keepsone-time-codeahead of tel hints on code fields, and avoids inferring email autofill when a mixed identifier usesinput_mode: "text".InputModeis exported from the package; a patch changeset documents the behavior.Reviewed by Cursor Bugbot for commit a5b00b0. Bugbot is set up for automated code reviews on this repo. Configure here.