Add support for x5t and x5t#S256 header #669
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hieuk09
force-pushed
the
feature/add-x5t
branch
3 times, most recently
from
f6e2067 to
28a5e72
Compare
|
@hieuk09 Did you have some reference for how this should work? Could take a look at that to educate myself a bit. |
anakinj
reviewed
Apr 7, 2025
anakinj
reviewed
Apr 7, 2025
Now when looking closer at the changes I found some links... |
anakinj
reviewed
Apr 7, 2025
|
Thank you for the detailed review. I'll take a look and fix all the comments tomorrow. |
|
@anakinj could you have another review? |
anakinj
reviewed
Apr 20, 2025
anakinj
reviewed
Apr 20, 2025
anakinj
reviewed
Apr 20, 2025
anakinj
reviewed
Apr 20, 2025
anakinj
reviewed
Apr 20, 2025
anakinj
reviewed
Apr 30, 2025
anakinj
reviewed
Apr 30, 2025
anakinj
reviewed
Apr 30, 2025
|
@hieuk09 Was there something pending for this one still. To my understanding the functionality for picking the key field is totally optional now? |
anakinj
reviewed
Jun 11, 2025
|
@anakinj I think there are no pending tasks for this PR, the key field should be totally optional now. |
anakinj
approved these changes
Jun 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Close #562
Checklist
Before the PR can be merged be sure the following are checked: