Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: co-badged card selection when priority scheme disabled #237

Merged
merged 3 commits into from
Mar 19, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/components/elements/CardElement.res
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,9 @@ let make = (
text,
expireRef: React.ref<Nullable.t<ReactNative.TextInput.element>>,
) => {
let cardBrand = getCardBrand(text)
let enabledCardSchemes = PaymentUtils.getCardNetworks(cardNetworks->Option.getOr(None))
let validCardBrand = getFirstValidCardScheme(~cardNumber=text, ~enabledCardSchemes)
let cardBrand = validCardBrand === "" ? getCardBrand(text) : validCardBrand
let num = formatCardNumber(text, cardType(cardBrand))

let isthisValid = cardValid(num, cardBrand)
Expand Down
13 changes: 3 additions & 10 deletions src/components/elements/CardSchemeComponent.res
Original file line number Diff line number Diff line change
Expand Up @@ -46,21 +46,14 @@ module CardSchemeSelectionPopoverElement = {
let make = (~cardNumber, ~cardNetworks) => {
let (cardData, setCardData) = React.useContext(CardDataContext.cardDataContext)

let cardBrand = Validation.getCardBrand(cardNumber)
let enabledCardSchemes = PaymentUtils.getCardNetworks(cardNetworks->Option.getOr(None))
let validCardBrand = Validation.getFirstValidCardScheme(~cardNumber, ~enabledCardSchemes)
let cardBrand = validCardBrand === "" ? Validation.getCardBrand(cardNumber) : validCardBrand
let (cardBrandIcon, setCardBrandIcon) = React.useState(_ =>
cardBrand === "" ? "waitcard" : cardBrand
)
let (dropDownIconWidth, _) = React.useState(_ => Animated.Value.create(0.))

let getCardNetworks = cardNetworks => {
switch cardNetworks {
| Some(cardNetworks) =>
cardNetworks->Array.map((item: PaymentMethodListType.card_networks) => item.card_network)
| None => []
}
}

let enabledCardSchemes = getCardNetworks(cardNetworks->Option.getOr(None))
let matchedCardSchemes = cardNumber->Validation.clearSpaces->Validation.getAllMatchedCardSchemes
let eligibleCardSchemes = Validation.getEligibleCoBadgedCardSchemes(
~matchedCardSchemes,
Expand Down
1 change: 0 additions & 1 deletion src/types/SamsungPayType.res
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,6 @@ let getShippingDetails = (dict): SdkTypes.addressDetails => {
->Option.getOr(Dict.make())

let fullName = getString(shippingDict, "addressee", "")
Console.log2("FullName", fullName)

let nameArr = String.split(fullName, " ")
let firstName = nameArr[0]->Option.getOr("")
Expand Down
8 changes: 8 additions & 0 deletions src/utility/logics/PaymentUtils.res
Original file line number Diff line number Diff line change
Expand Up @@ -181,3 +181,11 @@ let getActionType = (nextActionObj: option<PaymentConfirmTypes.nextAction>) => {
let actionType = nextActionObj->Option.getOr({type_: "", redirectToUrl: ""})
actionType.type_
}

let getCardNetworks = cardNetworks => {
switch cardNetworks {
| Some(cardNetworks) =>
cardNetworks->Array.map((item: PaymentMethodListType.card_networks) => item.card_network)
| None => []
}
}
15 changes: 12 additions & 3 deletions src/utility/reusableCodeFromWeb/Validation.res
Original file line number Diff line number Diff line change
Expand Up @@ -146,10 +146,19 @@ let getAllMatchedCardSchemes = cardNumber => {
})
}

let isCardSchemeEnabled = (~cardScheme, ~enabledCardSchemes) => {
enabledCardSchemes->Array.includes(cardScheme)
}

let getFirstValidCardScheme = (~cardNumber, ~enabledCardSchemes) => {
let allMatchedCards = getAllMatchedCardSchemes(cardNumber->clearSpaces)
allMatchedCards
->Array.find(card => isCardSchemeEnabled(~cardScheme=card, ~enabledCardSchemes))
->Option.getOr("")
}

let getEligibleCoBadgedCardSchemes = (~matchedCardSchemes, ~enabledCardSchemes) => {
matchedCardSchemes->Array.filter(ele =>
enabledCardSchemes->Array.includes(ele)
)
matchedCardSchemes->Array.filter(ele => enabledCardSchemes->Array.includes(ele))
}

let getCardBrand = cardNumber => {
Expand Down
Loading