New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: co-badged card selection when priority scheme disabled #237

Merged

sh-iv-am merged 3 commits into main from fix-card-scheme-selection

Mar 19, 2025

Contributor

Shivam25092001 commented Mar 6, 2025

FIXED

For a cobadge card, which supports Visa and Cartes Bancaires, if we disabled Visa from the backend and enabled only Cartes Bancaires. As a result, Cartes Bancaires appears in the available payment methods. However, when we enter the card number, it displays an error stating that the card brand is not supported.

Shivam25092001 requested review from Sanskar2001 and sh-iv-am

March 6, 2025 14:02


          fix: co-badged card selection when priority scheme disabled

3e48087

Shivam25092001 force-pushed the fix-card-scheme-selection branch from 4c4be9f to 3e48087 Compare

March 7, 2025 08:33

Shivam25092001 added 2 commits

March 7, 2025 14:17


          Merge branch 'main' into fix-card-scheme-selection

391507f


          refactor: removed commented console.log

ffa33d4

ci script test failed because found console.log in samsungPayTypes file. removed the unused console
log statement

sh-iv-am merged commit e4bcede into main

6 of 7 checks passed

sh-iv-am deleted the fix-card-scheme-selection branch

March 19, 2025 07:32

github-actions bot pushed a commit to manideepk90/hyperswitch-client-core that referenced this pull request


          chore(release): 1.0.0 [skip ci]

e0329f0

# 1.0.0 (2025-03-20)

### Bug Fixes

* active scrollview height ([d3664ac](d3664ac))
* add spaces to last name ([juspay#169](https://github.com/manideepk90/hyperswitch-client-core/issues/169)) ([1a669c1](1a669c1))
* added checkbox for saved payment method screen with conditions t… ([juspay#16](https://github.com/manideepk90/hyperswitch-client-core/issues/16)) ([7b201c6](7b201c6))
* added client_core_version to LoggerUtils ([c6c795b](c6c795b))
* added defaultTick icon for SavedPM ([juspay#152](https://github.com/manideepk90/hyperswitch-client-core/issues/152)) ([8967a2a](8967a2a))
* added Locale support for error messages ([juspay#15](https://github.com/manideepk90/hyperswitch-client-core/issues/15)) ([ecef552](ecef552))
* added locale support for hardcoded wallet description string ([juspay#57](https://github.com/manideepk90/hyperswitch-client-core/issues/57)) ([e182df9](e182df9))
* added locale support for saved payment method screen ([juspay#39](https://github.com/manideepk90/hyperswitch-client-core/issues/39)) ([132d35e](132d35e))
* added max cvv length support ([juspay#154](https://github.com/manideepk90/hyperswitch-client-core/issues/154)) ([36a6c26](36a6c26))
* added SafeArea top for iOS & removed unused dependencies ([juspay#2](https://github.com/manideepk90/hyperswitch-client-core/issues/2)) ([a3d7155](a3d7155))
* added Scancard and Netcetera as optional dependecy ([4bd0ea8](4bd0ea8))
* added sdk version to logs ([juspay#37](https://github.com/manideepk90/hyperswitch-client-core/issues/37)) ([d5e1781](d5e1781))
* added version-info ([240b2ad](240b2ad))
* android launch command added and keyboard hack removed ([c20c098](c20c098))
* animation fix on payment sheet ([juspay#3](https://github.com/manideepk90/hyperswitch-client-core/issues/3)) ([402a6e6](402a6e6))
* appearance fixes ([e62c919](e62c919))
* apple pay data collection fix ([3400854](3400854))
* applepay appearance fix ([juspay#62](https://github.com/manideepk90/hyperswitch-client-core/issues/62)) ([0b54035](0b54035))
* autoComplete text (keyboard flicker) ([b0553bd](b0553bd))
* border-width and radius value fixed ([juspay#161](https://github.com/manideepk90/hyperswitch-client-core/issues/161)) ([91a35c9](91a35c9))
* co-badged card selection when priority scheme disabled ([juspay#237](https://github.com/manideepk90/hyperswitch-client-core/issues/237)) ([e4bcede](e4bcede))
* co-badged scheme selection issue ([juspay#226](https://github.com/manideepk90/hyperswitch-client-core/issues/226)) ([dc1aa18](dc1aa18))
* code-push-patch conflict ([990f272](990f272))
* customer acceptance and nickname was not being sent in confirm p… ([juspay#8](https://github.com/manideepk90/hyperswitch-client-core/issues/8)) ([aec578d](aec578d))
* customer acceptance logic fixes ([37d3c42](37d3c42))
* customTab height fix ([juspay#166](https://github.com/manideepk90/hyperswitch-client-core/issues/166)) ([db1fdff](db1fdff))
* fix error description on input fields ([juspay#53](https://github.com/manideepk90/hyperswitch-client-core/issues/53)) ([3f7f512](3f7f512))
* fix hooks issues ([juspay#9](https://github.com/manideepk90/hyperswitch-client-core/issues/9)) ([40013b3](40013b3))
* fix: Headless function error handling ([ec453c4](ec453c4))
* fixed card brand validation for mastercard ([juspay#243](https://github.com/manideepk90/hyperswitch-client-core/issues/243)) ([47cc3ac](47cc3ac))
* fixed CardHolderName value and added lanugage support for error messages ([juspay#11](https://github.com/manideepk90/hyperswitch-client-core/issues/11)) ([fee919f](fee919f))
* fixed First Name and Last Name ([juspay#13](https://github.com/manideepk90/hyperswitch-client-core/issues/13)) ([c7bafbd](c7bafbd))
* fixed name not displaying and custom picker should pick initial value ([juspay#12](https://github.com/manideepk90/hyperswitch-client-core/issues/12)) ([7b61844](7b61844))
* fixed payment sheet and saved payment screen modal texts ([juspay#20](https://github.com/manideepk90/hyperswitch-client-core/issues/20)) ([b9d3e39](b9d3e39))
* fixed wrong validation in country state data s3 api call ([juspay#184](https://github.com/manideepk90/hyperswitch-client-core/issues/184)) ([2695c7a](2695c7a))
* flutter-crash-fix ([8469a8d](8469a8d))
* global context hierarchy ([juspay#239](https://github.com/manideepk90/hyperswitch-client-core/issues/239)) ([a2a80b8](a2a80b8))
* headless edge case ([0fa4a40](0fa4a40))
* headless error message ([64ee0e7](64ee0e7))
* height Issue fix ([f829f0e](f829f0e))
* infinite Loading Issue fix in various PM ([9961a31](9961a31))
* keyboard dismiss click on tooltip ([2ddacad](2ddacad))
* keyboard dismiss on tooltip visibility and common logic for padding ([145ace7](145ace7))
* loading Overlay to stop interaction ([7fc0ff3](7fc0ff3))
* migrated e2e pipelines to actions v4 ([juspay#203](https://github.com/manideepk90/hyperswitch-client-core/issues/203)) ([1783713](1783713))
* minimum height added to handle abruptness ([16c5a48](16c5a48))
* modal header UI ([juspay#111](https://github.com/manideepk90/hyperswitch-client-core/issues/111)) ([0ceeed4](0ceeed4))
* Modal Header Webview styling ([edc0de8](edc0de8))
* moved `defaultView` prop from `hyperParams` to `configuration` object ([juspay#216](https://github.com/manideepk90/hyperswitch-client-core/issues/216)) ([49df0af](49df0af))
* multiple email fields merged ([juspay#200](https://github.com/manideepk90/hyperswitch-client-core/issues/200)) ([bb2fe34](bb2fe34))
* name and custom picker ([juspay#14](https://github.com/manideepk90/hyperswitch-client-core/issues/14)) ([d16a09e](d16a09e))
* native navigation overlapping with confirm btn ([juspay#170](https://github.com/manideepk90/hyperswitch-client-core/issues/170)) ([54f2284](54f2284))
* netcetera fixes ([a402755](a402755))
* netcetera initialisation multiple times ([5dacfeb](5dacfeb))
* nickname input field and validation ([juspay#191](https://github.com/manideepk90/hyperswitch-client-core/issues/191)) ([e1d7256](e1d7256))
* no change in nickname if user send empty string in nickname field ([juspay#194](https://github.com/manideepk90/hyperswitch-client-core/issues/194)) ([f4ee5bd](f4ee5bd))
* orientation change field breaking fix ([ad1ae58](ad1ae58))
* padding in scrollview bottomsheet ([juspay#172](https://github.com/manideepk90/hyperswitch-client-core/issues/172)) ([9799eba](9799eba))
* patch flutter 1.3.1-patch1 ([297f60b](297f60b))
* payment session call fix ([8f94380](8f94380))
* pipeline fix ([juspay#205](https://github.com/manideepk90/hyperswitch-client-core/issues/205)) ([e757455](e757455))
* primary button color fixes ([514b8ff](514b8ff))
* remove leading spaces on nickname input field ([juspay#198](https://github.com/manideepk90/hyperswitch-client-core/issues/198)) ([1b6a0a2](1b6a0a2))
* removed error-msg on initial focus ([juspay#159](https://github.com/manideepk90/hyperswitch-client-core/issues/159)) ([a26e086](a26e086))
* removed the focus on confirm click ([juspay#158](https://github.com/manideepk90/hyperswitch-client-core/issues/158)) ([6a60516](6a60516))
* removing card_holder_name if present in saved cards flow ([juspay#26](https://github.com/manideepk90/hyperswitch-client-core/issues/26)) ([bc768ce](bc768ce))
* removing plaid dependency temp ([162cfec](162cfec))
* rescript compilation errors ([8845fb6](8845fb6))
* revert PR stop progressbar for frictionless flow ([da7a703](da7a703))
* rounded corner fix ([68ef192](68ef192))
* save new payment method flow ([juspay#130](https://github.com/manideepk90/hyperswitch-client-core/issues/130)) ([d62cab9](d62cab9))
* saved pm sorting logic ([4e01c75](4e01c75))
* Scrollview keyboardShouldPersistTaps fix ([68c3ed2](68c3ed2))
* sentry initialization removed for Headless Mode ([b545f92](b545f92))
* sentry initialization removed for Headless Mode ([juspay#17](https://github.com/manideepk90/hyperswitch-client-core/issues/17)) ([7a89bc3](7a89bc3))
* sheet dismiss timeout fixes ([b1cc6e8](b1cc6e8))
* show version info ([c2adc14](c2adc14))
* stop progressbar for frictionless flow ([6dda2ee](6dda2ee))
* theme support for Platform Pay Buttons ([e766bf7](e766bf7))
* tooltip position correction ([82f7a73](82f7a73))
* translation for cardHolderName is fixed ([juspay#180](https://github.com/manideepk90/hyperswitch-client-core/issues/180)) ([ce63430](ce63430))
* ui and config for pmm ([juspay#109](https://github.com/manideepk90/hyperswitch-client-core/issues/109)) ([319a65d](319a65d))
* ui interaction for ClickableTextElement ([juspay#160](https://github.com/manideepk90/hyperswitch-client-core/issues/160)) ([2fa238a](2fa238a))
* validation errors on blur for nickname ([juspay#151](https://github.com/manideepk90/hyperswitch-client-core/issues/151)) ([8991212](8991212))
* validation messages for cvv and expiry-date ([juspay#155](https://github.com/manideepk90/hyperswitch-client-core/issues/155)) ([ed073e4](ed073e4))
* validation rules for card holder's name and nickname ([juspay#143](https://github.com/manideepk90/hyperswitch-client-core/issues/143)) ([5e9a5f4](5e9a5f4))

### Features

* added api in demo server to replicate s2s call for pmm ([juspay#122](https://github.com/manideepk90/hyperswitch-client-core/issues/122)) ([2fbeaf9](2fbeaf9))
* added card network supported validation ([juspay#189](https://github.com/manideepk90/hyperswitch-client-core/issues/189)) ([ee551f4](ee551f4))
* added conditional S3 api call and used local states and countries for gpay and applepay ([juspay#182](https://github.com/manideepk90/hyperswitch-client-core/issues/182)) ([3c658a1](3c658a1))
* added cvv field on saved pm screen ([juspay#18](https://github.com/manideepk90/hyperswitch-client-core/issues/18)) ([805f970](805f970))
* added device check and logs ([juspay#215](https://github.com/manideepk90/hyperswitch-client-core/issues/215)) ([eae1811](eae1811))
* added external 3ds support using netcetera ([juspay#6](https://github.com/manideepk90/hyperswitch-client-core/issues/6)) ([4007585](4007585))
* added payment method - EPS ([juspay#54](https://github.com/manideepk90/hyperswitch-client-core/issues/54)) ([2fe9ccf](2fe9ccf))
* added payment method - sofort ([juspay#60](https://github.com/manideepk90/hyperswitch-client-core/issues/60)) ([30611c4](30611c4))
* added payment method - trustly ([juspay#64](https://github.com/manideepk90/hyperswitch-client-core/issues/64)) ([2abedcb](2abedcb))
* added payment method iDEAL ([juspay#59](https://github.com/manideepk90/hyperswitch-client-core/issues/59)) ([73d62e4](73d62e4))
* added portal support ([juspay#210](https://github.com/manideepk90/hyperswitch-client-core/issues/210)) ([4847701](4847701))
* added react native detox framework for e2e automation ([juspay#165](https://github.com/manideepk90/hyperswitch-client-core/issues/165)) ([0145a42](0145a42))
* added samsung pay ([juspay#112](https://github.com/manideepk90/hyperswitch-client-core/issues/112)) ([a5056fd](a5056fd))
* added support to collect billing from spay ([juspay#224](https://github.com/manideepk90/hyperswitch-client-core/issues/224)) ([44c82f4](44c82f4))
* added x-redirect-uri in headers ([juspay#91](https://github.com/manideepk90/hyperswitch-client-core/issues/91)) ([132c714](132c714))
* android webview sdk ([e1eb7b1](e1eb7b1))
* api-handler for saving new payment method ([juspay#118](https://github.com/manideepk90/hyperswitch-client-core/issues/118)) ([1255653](1255653))
* apple pay native view ([juspay#24](https://github.com/manideepk90/hyperswitch-client-core/issues/24)) ([ce305c2](ce305c2))
* blik payment method ([juspay#49](https://github.com/manideepk90/hyperswitch-client-core/issues/49)) ([2b345c7](2b345c7))
* displayDefaultSavedPaymentIcon prop added ([juspay#22](https://github.com/manideepk90/hyperswitch-client-core/issues/22)) ([c283af3](c283af3))
* googlePay button view ([5e10a05](5e10a05))
* header for platform added ([95134c3](95134c3))
* hot reloading for web ([juspay#103](https://github.com/manideepk90/hyperswitch-client-core/issues/103)) ([09bca1e](09bca1e))
* moved countries and states to S3 ([juspay#173](https://github.com/manideepk90/hyperswitch-client-core/issues/173)) ([8c8159f](8c8159f))
* new text wrapper and props for different text types are added ([juspay#19](https://github.com/manideepk90/hyperswitch-client-core/issues/19)) ([25a457f](25a457f))
* plaid sdk pis flow ([juspay#76](https://github.com/manideepk90/hyperswitch-client-core/issues/76)) ([39665f2](39665f2))
* platformButtons added ([juspay#69](https://github.com/manideepk90/hyperswitch-client-core/issues/69)) ([3119d79](3119d79))
* pmm add pm button ([juspay#119](https://github.com/manideepk90/hyperswitch-client-core/issues/119)) ([db9a2b7](db9a2b7))
* publish automation for android ([juspay#140](https://github.com/manideepk90/hyperswitch-client-core/issues/140)) ([1820cbb](1820cbb))
* router for payment method management ([juspay#93](https://github.com/manideepk90/hyperswitch-client-core/issues/93)) ([149bd42](149bd42))

### Reverts

* applepay-appearance-fix revert ([juspay#66](https://github.com/manideepk90/hyperswitch-client-core/issues/66)) ([b0c1200](b0c1200))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet