Skip to content

Drop support for Python 3.7 #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 10, 2023
Merged

Drop support for Python 3.7 #387

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cfffc60
Drop support for Python 3.7
consideRatio Apr 7, 2023
6e340b1
ci: add back test for jupyter_server 1
consideRatio Apr 8, 2023
1d9e037
ci: test against jupyter-notebook and jupyter-lab in the same job
consideRatio Apr 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 16 additions & 10 deletions .github/workflows/test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,9 @@ jobs:
strategy:
fail-fast: false
matrix:
python-version: ["3.8", "3.11"]
jupyter_server-version: ["1", "2"]
jupyterlab-version: ["2", "3"]
python-version: ["3.7", "3.11"]
jupyter-app: [notebook, lab]

steps:
- uses: actions/checkout@v3
Expand Down Expand Up @@ -69,16 +69,23 @@ jobs:
#
# Pytest options are set in tests/pytest.ini.
run: |
pip install -vv $(ls ./dist/jupyter_server_proxy-*.whl)\[acceptance\] 'jupyterlab~=${{ matrix.jupyterlab-version }}.0'
pip install -vv $(ls ./dist/jupyter_server_proxy-*.whl)\[acceptance\] 'jupyterlab~=${{ matrix.jupyterlab-version }}.0' 'jupyter_server~=${{ matrix.jupyter_server-version }}.0'

- name: List Python packages
run: |
pip freeze
pip check

- name: Run tests
- name: Run tests against jupyter-notebook
run: |
JUPYTER_TOKEN=secret jupyter-${{ matrix.jupyter-app }} --config=./tests/resources/jupyter_server_config.py &
JUPYTER_TOKEN=secret jupyter-notebook --config=./tests/resources/jupyter_server_config.py &
sleep 5
cd tests
pytest -k "not acceptance"

- name: Run tests against jupyter-lab
run: |
JUPYTER_TOKEN=secret jupyter-lab --config=./tests/resources/jupyter_server_config.py &
sleep 5
cd tests
pytest -k "not acceptance"
Expand All @@ -88,7 +95,7 @@ jobs:
uses: actions/upload-artifact@v3
with:
name: |-
unit-tests-${{ matrix.python-version }}-${{ matrix.jupyter-app }}-${{ matrix.jupyterlab-version }}-${{ github.run_number }}
unit-tests-${{ matrix.python-version }}-${{ matrix.jupyterlab-version }}-${{ github.run_number }}
path: |
./build/pytest
./build/coverage
Expand All @@ -115,10 +122,9 @@ jobs:
- name: Check the lab extension
# We test the labextension thoroughly in the acceptance tests below, so
# we have conditionally disabled this basic check is to avoid issues in
# jupyterlab.browser_check with jupyterlab 2 and a modern version of
# python (3.11+).
# jupyterlab.browser_check with jupyterlab 2 and jupyter_server 2+.
#
if: ${{ !(matrix.jupyterlab-version == '2' && startsWith(matrix.python-version, '3.11')) }}
if: ${{ !(matrix.jupyterlab-version == '2' && matrix.jupyter_server-version != '1') }}
run: |
jupyter labextension list
jupyter labextension list 2>&1 | grep -iE '@jupyterhub/jupyter-server-proxy.*OK.*'
Expand All @@ -133,6 +139,6 @@ jobs:
uses: actions/upload-artifact@v3
with:
name: |-
acceptance-tests-${{ matrix.python-version }}-${{ matrix.jupyter-app }}-${{ matrix.jupyterlab-version }}-${{ github.run_number }}
acceptance-tests-${{ matrix.python-version }}-${{ matrix.jupyterlab-version }}-${{ github.run_number }}
path: |
./build/robot
3 changes: 1 addition & 2 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ dynamic = [
]
readme = "README.md"
license = { file = "LICENSE" }
requires-python = ">=3.7"
requires-python = ">=3.8"
classifiers = [
"Framework :: Jupyter",
"Framework :: Jupyter :: JupyterLab",
Expand All @@ -32,7 +32,6 @@ classifiers = [
"Operating System :: POSIX :: Linux",
"Programming Language :: Python",
"Programming Language :: Python :: 3",
"Programming Language :: Python :: 3.7",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
Expand Down