Drop support for Python 3.7 #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
consideRatio
force-pushed
the
pr/req-py38
branch
from
9b49f3d to
03989d7
Compare
consideRatio
force-pushed
the
pr/req-py38
branch
from
8b28217 to
83613a6
Compare
This test was never explicit in the past, but we did it in the Python 3.7 setup as then jupyter_server 2 couldn't be installed.
consideRatio
force-pushed
the
pr/req-py38
branch
from
83613a6 to
6e340b1
Compare
Closed
manics
approved these changes
Apr 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next release is 4.0.0 as we have breaking changes (#388), I figure we should drop support for Python 3.7 as part of it as this PR does.
Adjustments to tests
Previously we tested against jupyter_server 1 in one specific test job, in the one with Python 3.7. When this was removed we no longer tested against it. So I've added
jupyter_server-versionto the test matrix. Doing so we went from 8 to 16 jobs though which is quite a lot.I considered how to reduce the large amounts of jobs, and concluded a reasonable strategy was to add another job step and remove the
jupyter-apptest matrix variable. So, now we have two steps in sequence, running pytest first against ajupyter-notebookserver then against ajupyter-labserver. This duplicated step takes ~13 second, so its a small step compared to the job that takes ~3-4 minutes.