Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Coremod, add mcmod.info #10

Open
wants to merge 2 commits into
base: 1.7.10
Choose a base branch
from
Open

Remove Coremod, add mcmod.info #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
600155a
Remove DepLoader
glowredman Mar 1, 2025
970bb76
Add mcmod.info
glowredman Mar 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,11 @@ modName = Baubles Expanded

# Case-sensitive identifier string, available for mcmod.info population and used for automatic mixin JSON generation.
# Conventionally lowercase.
modId = BaublesExpanded
modId = Baubles\u007cExpanded

# Root package of the mod, used to find various classes in other properties,
# mcmod.info substitution, enabling assertions in run tasks, etc.
modGroup =
modGroup = baubles

# Whether to use modGroup as the maven publishing group.
# Due to a history of using JitPack, the default is com.github.GTNewHorizons for all mods.
Expand Down Expand Up @@ -75,7 +75,7 @@ replaceGradleTokenInFile =
# In case your mod provides an API for other mods to implement you may declare its package here. Otherwise, you can
# leave this property empty.
# Example value: (apiPackage = api) + (modGroup = com.myname.mymodid) -> com.myname.mymodid.api
apiPackage =
apiPackage = api

# Specify the configuration file for Forge's access transformers here. It must be placed into /src/main/resources/META-INF/
# There can be multiple files in a space-separated list.
Expand All @@ -102,7 +102,7 @@ mixinsPackage =
# Specify the core mod entry class if you use a core mod. This class must implement IFMLLoadingPlugin!
# This parameter is for legacy compatibility only
# Example value: (coreModClass = asm.FMLPlugin) + (modGroup = com.myname.mymodid) -> com.myname.mymodid.asm.FMLPlugin
coreModClass = thaumcraft.codechicken.core.launch.DepLoader
coreModClass =

# If your project is only a consolidation of mixins or a core mod and does NOT contain a 'normal' mod ( = some class
# that is annotated with @Mod) you want this to be true. When in doubt: leave it on false!
Expand Down Expand Up @@ -170,7 +170,7 @@ curseForgeRelations =

# Optional parameter to customize the produced artifacts. Use this to preserve artifact naming when migrating older
# projects. New projects should not use this parameter.
# customArchiveBaseName =
customArchiveBaseName = BaublesExpanded

# Optional parameter to have the build automatically fail if an illegal version is used.
# This can be useful if you e.g. only want to allow versions in the form of '1.1.xxx'.
Expand Down
41 changes: 0 additions & 41 deletions src/main/java/thaumcraft/codechicken/core/launch/DepLoader.java
View file
Open in desktop
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The coremod is a dummy to stop Thaumcraft 4 from downloading standard Baubles, and should not be removed unless replaced with a better soloution.
I think GTNH uses an altered Thaumcraft jar to entirely work around the issue, but that won't work well for non-GTNH users.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense but it isn't even loaded by FML currently. Due to how the buildscript works, the entry in MANIFEST.MF is .thaumcraft.codechicken.core.launch.DepLoader (note the dot at the beginning).

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does still result in TC4 not being able to download Baubles, at least on the setups I have tested it with. I have been considering a Mixins dependency to make some compatibility improvements to the few ARR mods that do not properly detect stuff after the first four slots. Using it to propelry kill the dep loader as well would probably be a good idea.

This file was deleted.

21 changes: 21 additions & 0 deletions src/main/resources/mcmod.info
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
{
"modListVersion": 2,
"modList": [{
"modid": "${modId}",
"name": "${modName}",
"description": "Adding a touch of bling to Minecraft",
"version": "${modVersion}",
"mcversion": "${minecraftVersion}",
"url": "https://github.com/jss2a98aj/Baubles-Expanded",
"updateUrl": "",
"authorList": ["Azanor", "jss2a98aj"],
"credits": "Special thanks to chicken_bones",
"logoFile": "BLogo.png",
"screenshots": [],
"parent": "",
"requiredMods": [],
"dependencies": [],
"dependants": [],
"useDependencyInformation": false
}]
}