Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Coremod, add mcmod.info #10

Open
wants to merge 2 commits into
base: 1.7.10
Choose a base branch
from

Conversation

glowredman
Copy link

  • Use same modID in gradle.properties as in @Mod annotation
  • Define API package
  • Remove coremod (unused)
  • Add mcmod.info file (I used this as template, if you want any further changes lmk)

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The coremod is a dummy to stop Thaumcraft 4 from downloading standard Baubles, and should not be removed unless replaced with a better soloution.
I think GTNH uses an altered Thaumcraft jar to entirely work around the issue, but that won't work well for non-GTNH users.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense but it isn't even loaded by FML currently. Due to how the buildscript works, the entry in MANIFEST.MF is .thaumcraft.codechicken.core.launch.DepLoader (note the dot at the beginning).

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does still result in TC4 not being able to download Baubles, at least on the setups I have tested it with. I have been considering a Mixins dependency to make some compatibility improvements to the few ARR mods that do not properly detect stuff after the first four slots. Using it to propelry kill the dep loader as well would probably be a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants