Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

patch: GOTG_2.1.1 #159

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

patch: GOTG_2.1.1 #159

wants to merge 1 commit into from

Conversation

francisdb
Copy link
Contributor

@francisdb francisdb commented Nov 28, 2023 •
edited
Loading

https://vpuniverse.com/files/file/6127-guardians-of-the-galaxy/

Does not make a lot of sense without pup pack support but you can at least play the table.

Pup pack mostly works, probably needs some more fixes in the pup code like vpinball/vpinball#2237

@francisdb francisdb marked this pull request as draft January 9, 2024 10:49
@francisdb francisdb mentioned this pull request Jan 9, 2024
Open
@francisdb francisdb mentioned this pull request Mar 13, 2025
Merged
@francisdb francisdb marked this pull request as ready for review March 14, 2025 08:17
@francisdb
Copy link
Contributor Author

@jsm174 ready for review

@francisdb
Copy link
Contributor Author

Meh, saw a game going into an infinite loop

2025-03-14 17:47:40.398 INFO  [497821] [DebuggerModule::Print@4274] Script.Print 'ModePoints: 471450'
2025-03-14 17:47:40.400 INFO  [497821] [DebuggerModule::Print@4274] Script.Print 'ModePoints: 471450'
2025-03-14 17:47:40.402 INFO  [497821] [DebuggerModule::Print@4274] Script.Print 'ModePoints: 471450'
...

@francisdb francisdb marked this pull request as draft March 14, 2025 16:48
@francisdb francisdb mentioned this pull request Mar 14, 2025
Open
@francisdb
Copy link
Contributor Author

vpinball issue causing the loop fixed but still having issues with this table/pup pack

@francisdb
Copy link
Contributor Author

francisdb commented Mar 16, 2025 •
edited
Loading

With vpinball/vpinball#2252 this table is playable. Further improvements will need to be done on the pup implementation code.

@francisdb francisdb marked this pull request as ready for review March 16, 2025 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@francisdb