Skip to content

starrysystems.js.org #9667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
+1 −0
Closed

starrysystems.js.org #9667

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2d35ff2
Update cnames_active.js
lakshinhemachandran Mar 31, 2025
849d32e
Merge pull request #1 from Starry-Systems/lakshinhemachandran-patch-1
lakshinhemachandran Mar 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cnames_active.js
View file
Original file line number Diff line number Diff line change
@@ -38,6 +38,7 @@
*/

var cnames_active = {
"starrysystems": "starry-systems.github.io",

Check failure on line 41 in cnames_active.js

GitHub Actions / validate 

Expected no line, but found `  "starrysystems": "starry-systems.github.io",`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"starrysystems": "starry-systems.github.io",
"starrysystems": "starry-systems.github.io/website",

If you're wanting to target https://github.com/Starry-Systems/website, then you need to include that path here

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, as the CI (and the file itself) notes, your entry needs to be added in alphabetical order, please.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also also, https://github.com/Starry-Systems/website is not content that we're going to accept in its current state -- it is very clearly just placeholder content: https://github.com/Starry-Systems/website/blob/7f14547c10ff45e76d7029fee429ef7816d416aa/index.html

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok.

"": "js-org.github.io",
"01mz": "01mz.github.io",
"100dayz": "deadcoder0904.github.io/100dayz",
@@ -3101,7 +3102,7 @@
"stapp": "tinkoffcreditsystems.github.io/stapp",
"starfield": "annikav9.github.io/starfield.js",
"starify-discord": "dastormer.github.io/starify-discord",
"starratio": "starratio.github.io/star-ratio", // noCF

Check failure on line 3105 in cnames_active.js

GitHub Actions / validate 

Expected to find `  "starrysystems": "starry-systems.github.io",` after existing line
"start": "deepsweet.github.io/start",
"starterdocs": "vtempest.github.io/Serverless-DOCS-Stack",
"starterpk": "starterpk.github.io",